Skip to content

type check for torch.testing._internal.common_utils #45375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
walterddr wants to merge 1 commit into from
Closed

type check for torch.testing._internal.common_utils #45375

walterddr wants to merge 1 commit into from

Conversation

@walterddr
Copy link
Contributor

@walterddr walterddr commented Sep 26, 2020

part of torch.testing._internal.* effort

@dr-ci
Copy link

dr-ci bot commented Sep 26, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit a5047a2 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

1 job timed out:

  • pytorch_linux_xenial_py3_clang5_asan_test2
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 15 times.

@walterddr walterddr force-pushed the gh/walterddr/typecheck_5 branch from 2ce6bf5 to 3a4a6e6 Compare September 26, 2020 15:51
@walterddr walterddr changed the title enable type check for torch.testing._internal.common_utils type check for torch.testing._internal.common_utils Sep 28, 2020
@walterddr walterddr force-pushed the gh/walterddr/typecheck_5 branch from 3a4a6e6 to a5047a2 Compare September 28, 2020 15:33
facebook-github-bot
facebook-github-bot reviewed Sep 28, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@walterddr walterddr marked this pull request as ready for review September 28, 2020 16:39
@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #45375 into master will decrease coverage by 0.00%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #45375      +/-   ##
==========================================
- Coverage   68.05%   68.05%   -0.01%     
==========================================
  Files         396      396              
  Lines       51232    51237       +5     
==========================================
+ Hits        34865    34868       +3     
- Misses      16367    16369       +2
Impacted Files Coverage Δ
torch/testing/_internal/common_utils.py 77.12% <95.65%> (+0.01%) ⬆️
torch/testing/_internal/expecttest.py 77.55% <0.00%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4950a0...a5047a2. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 29, 2020

@walterddr merged this pull request in 49b198c.

@facebook-github-bot facebook-github-bot deleted the gh/walterddr/typecheck_5 branch January 27, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@walterddr @facebook-github-bot @mruberry