Skip to content

type check for torch.testing._internalcodegen:* #45368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
walterddr wants to merge 1 commit into from
Closed

type check for torch.testing._internalcodegen:* #45368

walterddr wants to merge 1 commit into from

Conversation

@walterddr
Copy link
Contributor

@walterddr walterddr commented Sep 25, 2020

part of torch.testing._internal.* effort

@dr-ci
Copy link

dr-ci bot commented Sep 26, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 4627857 (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

Extra GitHub checks: 1 failed

codecov.io: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 8 times.

facebook-github-bot
facebook-github-bot reviewed Sep 26, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@walterddr walterddr changed the title fix type check for torch.testing._internalcodegen:* type check for torch.testing._internalcodegen:* Sep 28, 2020
@walterddr walterddr force-pushed the gh/walterddr/typecheck_4 branch from 01bbe11 to 4627857 Compare September 28, 2020 15:33
facebook-github-bot
facebook-github-bot reviewed Sep 28, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Sep 28, 2020 •
edited
Loading

Codecov Report

Merging #45368 into master will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #45368   +/-   ##
=======================================
  Coverage   68.05%   68.05%           
=======================================
  Files         396      396           
  Lines       51232    51233    +1     
=======================================
+ Hits        34865    34866    +1     
  Misses      16367    16367
Impacted Files Coverage Δ
...orch/testing/_internal/codegen/random_topo_test.py 10.04% <50.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4950a0...4627857. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 28, 2020

@walterddr merged this pull request in 986af53.

@facebook-github-bot facebook-github-bot deleted the gh/walterddr/typecheck_4 branch January 27, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@walterddr @facebook-github-bot @mruberry