Skip to content

Change type inferred from empty annotation #45360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ansley wants to merge 6 commits into from
Closed

Change type inferred from empty annotation #45360

ansley wants to merge 6 commits into from

Conversation

@ansley
Copy link

@ansley ansley commented Sep 25, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D24078645

@ansley ansley requested a review from apaszke as a code owner September 25, 2020 21:03
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Sep 25, 2020
@ansley ansley linked an issue Sep 25, 2020 that may be closed by this pull request
[JIT] Type inferred from empty annotation should be Tensor with inferred=true #39772
Closed
@dr-ci
Copy link

dr-ci bot commented Sep 25, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 741b156 (more details on the Dr. CI page):

Commit 741b156 was recently pushed. Waiting for builds...

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 12 times.

ansley pushed a commit that referenced this pull request Sep 26, 2020
Change type inferred from empty annotation
49daf21 
ghstack-source-id: dfd4206
Pull Request resolved: #45360
@codecov
Copy link

codecov bot commented Sep 26, 2020 •
edited
Loading

Codecov Report

Merging #45360 into gh/ansleyadelaide/6/base will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           gh/ansleyadelaide/6/base   #45360      +/-   ##
============================================================
+ Coverage                     68.50%   68.56%   +0.06%     
============================================================
  Files                           408      405       -3     
  Lines                         52484    51955     -529     
============================================================
- Hits                          35952    35621     -331     
+ Misses                        16532    16334     -198
Impacted Files Coverage Δ
torch/jit/annotations.py 92.16% <100.00%> (ø)
torch/onnx/symbolic_opset10.py 36.25% <0.00%> (-3.75%) ⬇️
torch/fx/experimental/GraphManipulation.py 90.90% <0.00%> (-3.54%) ⬇️
torch/autograd/profiler.py 78.55% <0.00%> (-2.45%) ⬇️
torch/testing/_internal/jit_utils.py 87.93% <0.00%> (-1.76%) ⬇️
torch/utils/data/dataset.py 93.47% <0.00%> (-1.17%) ⬇️
torch/testing/_internal/common_utils.py 77.21% <0.00%> (-1.12%) ⬇️
torch/nn/parallel/distributed.py 41.43% <0.00%> (-1.05%) ⬇️
torch/utils/data/_utils/worker.py 20.75% <0.00%> (-0.75%) ⬇️
torch/nn/quantized/functional.py 62.75% <0.00%> (-0.51%) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77cd8e0...519ee64. Read the comment docs.

@ansley ansley requested a review from gmagogsfm September 26, 2020 10:11
gmagogsfm
gmagogsfm reviewed Sep 26, 2020
View reviewed changes
Copy link
Contributor

@gmagogsfm gmagogsfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test? Thanks.

ansley pushed a commit that referenced this pull request Sep 29, 2020
Change type inferred from empty annotation
acce6eb 
ghstack-source-id: 0102af2
Pull Request resolved: #45360
ansley pushed a commit that referenced this pull request Oct 1, 2020
Change type inferred from empty annotation
a26a83e 
ghstack-source-id: b5d6818
Pull Request resolved: #45360
ansley pushed a commit that referenced this pull request Oct 2, 2020
Change type inferred from empty annotation
aee629e 
ghstack-source-id: c293066
Pull Request resolved: #45360
ansley pushed a commit that referenced this pull request Oct 4, 2020
Change type inferred from empty annotation
8f6f83e 
ghstack-source-id: 6d74aaf
Pull Request resolved: #45360
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 6, 2020

@ansley merged this pull request in f18cc9c.

@facebook-github-bot facebook-github-bot deleted the gh/ansleyadelaide/6/head branch October 9, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmagogsfm gmagogsfm gmagogsfm approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[JIT] Type inferred from empty annotation should be Tensor with inferred=true

5 participants

@ansley @facebook-github-bot @gmagogsfm @mruberry