Skip to content

Disable complex inputs to torch.round #45330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Kiyosora wants to merge 2 commits into from
Closed

Disable complex inputs to torch.round #45330

Kiyosora wants to merge 2 commits into from

Conversation

@Kiyosora
Copy link
Contributor

@Kiyosora Kiyosora commented Sep 25, 2020 •
edited
Loading

@dr-ci
Copy link

dr-ci bot commented Sep 25, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 2eff6e0 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 21 times.

@Kiyosora Kiyosora force-pushed the disable_complex_to_torch_round branch 2 times, most recently from d0f2760 to 423f5f1 Compare September 27, 2020 01:24
@Kiyosora Kiyosora changed the title [WIP] Disable complex inputs to torch.round Disable complex inputs to torch.round Sep 27, 2020
@Kiyosora Kiyosora marked this pull request as ready for review September 27, 2020 09:12
@Kiyosora Kiyosora force-pushed the disable_complex_to_torch_round branch from 423f5f1 to 601803a Compare September 27, 2020 09:59
@codecov
Copy link

codecov bot commented Sep 27, 2020 •
edited
Loading

Codecov Report

Merging #45330 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #45330   +/-   ##
=======================================
  Coverage   68.15%   68.15%           
=======================================
  Files         396      396           
  Lines       51137    51137           
=======================================
+ Hits        34850    34851    +1     
+ Misses      16287    16286    -1
Impacted Files Coverage Δ
torch/testing/_internal/expecttest.py 78.57% <0.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b839bc...2eff6e0. Read the comment docs.

@Kiyosora Kiyosora force-pushed the disable_complex_to_torch_round branch from 601803a to 2eff6e0 Compare September 28, 2020 03:03
@gchanan gchanan requested a review from anjali411 September 28, 2020 15:39
@gchanan gchanan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 28, 2020
@anjali411 anjali411 added the module: complex Related to complex number support in PyTorch label Sep 28, 2020
facebook-github-bot
facebook-github-bot reviewed Sep 28, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 29, 2020

@anjali411 merged this pull request in 8c66cd1.

@mruberry mruberry mentioned this pull request Dec 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@anjali411 anjali411 anjali411 approved these changes

Assignees

No one assigned

Labels

Merged module: complex Related to complex number support in PyTorch open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Kiyosora @facebook-github-bot @anjali411 @gchanan @pytorchbot @mruberry