SyncBN: preserve qconfig if it exists #45317
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Eager mode quantization depends on the presence of the `config` model attribute. Currently converting a model to use `SyncBatchNorm` removes the qconfig - fixing this. This is important if a BN is not fused to anything during quantization convert. Test Plan: ``` python test/test_quantization.py TestDistributed.test_syncbn_preserves_qconfig ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Sep 25, 2020
Summary: Eager mode quantization depends on the presence of the `config` model attribute. Currently converting a model to use `SyncBatchNorm` removes the qconfig - fixing this. This is important if a BN is not fused to anything during quantization convert. Test Plan: ``` python test/test_quantization.py TestDistributed.test_syncbn_preserves_qconfig ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 97e74c3 Pull Request resolved: #45317
jerryzh168
approved these changes
Sep 25, 2020
Codecov Report
@@ Coverage Diff @@
## gh/vkuzo/152/base #45317 +/- ##
==================================================
Coverage 68.10% 68.11%
==================================================
Files 393 393
Lines 50945 50947 +2
==================================================
+ Hits 34697 34700 +3
+ Misses 16248 16247 -1
Continue to review full report at Codecov.
|
Contributor
|
This pull request has been merged in bdf329e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Eager mode quantization depends on the presence of the
configmodel attribute. Currently converting a model to use
SyncBatchNormremoves the qconfig - fixing this. This is important if a BN is not
fused to anything during quantization convert.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D23922072