replaced whitelist with allowlist #45260
Conversation
💊 CI failures summary and remediationsAs of commit b87361b (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 3 times. |
Codecov Report
@@ Coverage Diff @@
## master #45260 +/- ##
=======================================
Coverage 67.92% 67.92%
=======================================
Files 385 385
Lines 50164 50164
=======================================
Hits 34073 34073
Misses 16091 16091 Continue to review full report at Codecov.
|
|
@SplitInfinity Please review it. |
zou3519
added
the
triaged
SplitInfinity
left a comment
SplitInfinity
left a comment
There was a problem hiding this comment.
Thanks for working on this. Please undo the changes to one file that are not part of the task.
| torch.Tensor | ||
| =================================== | ||
|
|
||
| A :class:`torch.Tensor` is a multi-dimensional matrix containing elements of |
There was a problem hiding this comment.
Please undo the changes to this file. They are not part of task.
There was a problem hiding this comment.
no worries, I've reverted this file when importing to Phabricator (I need change an internal BUCK reference to the renamed file, too).
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ljk53 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Since I'm new here in open source world, so I don't know what to do next? |
|
There is nothing left to do. This repository works slightly different than others in the sense that the source of truth is an internal Facebook repository to which commits are merged, and then an automated job makes those same commits in the GitHub repository. That's why your PR with closed without being merged. |
7 participants
Fixes #41754
(1)
Intially file was named gen_op_registration_whitelist.py I changed it to gen_op_registration_allowlist.py
(2)
There were some whitelist in comment inside the file, I changed it to allowlist