Fix test_rpc_profiling_remote_record_function #45162
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was flaky because it was not able to validate that the overall record_function's CPU times are greater than the sum of its children. It turns out that this is a general bug in the profiler that can be reproduced without RPC, see #45160. Hence, removing this from the test and replacing it by just validating the expected children. Ran the test 1000 times and they all passed. Differential Revision: [D23851854](https://our.internmc.facebook.com/intern/diff/D23851854/) [ghstack-poisoned]
rohan-varma
requested review from
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
rohan-varma
added a commit
that referenced
this pull request
Sep 22, 2020
This test was flaky because it was not able to validate that the overall record_function's CPU times are greater than the sum of its children. It turns out that this is a general bug in the profiler that can be reproduced without RPC, see #45160. Hence, removing this from the test and replacing it by just validating the expected children. Ran the test 1000 times and they all passed. Differential Revision: [D23851854](https://our.internmc.facebook.com/intern/diff/D23851854/) ghstack-source-id: 112632327 Pull Request resolved: #45162
mrshenli
approved these changes
Sep 22, 2020
Codecov Report
@@ Coverage Diff @@
## gh/rohan-varma/177/base #45162 +/- ##
===========================================================
- Coverage 67.83% 67.81% -0.02%
===========================================================
Files 384 384
Lines 50047 50062 +15
===========================================================
+ Hits 33950 33952 +2
- Misses 16097 16110 +13
Continue to review full report at Codecov.
|
💊 CI failures summary and remediationsAs of commit 17880e4 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
codecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. |
Contributor
|
This pull request has been merged in bee1d44. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Closes #45067, #45145. This test was flaky because it was not able to validate that the
overall record_function's CPU times are greater than the sum of its children.
It turns out that this is a general bug in the profiler that can be reproduced
without RPC, see #45160. This means that it should be fixed and tested at the profiler, not RPC, level. Hence,
removing this from the test and replacing it by just validating the expected
children.
Ran the test 1000 times and they all passed.
Differential Revision: D23851854