[TensorExpr] Fix operator order in combineMultilane #45157
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
Summary: combineMultilane used the wrong order when ramp was on the left hand side, which matters for subtract. Test Plan: test_tensorexpr --gtest_filter=TensorExprTest.SimplifyRampSubBroadcast Reviewers: Subscribers: Tasks: Tags:
asuhan
force-pushed
the
asuhan/fix_combine_multilane
branch
from
3576c12 to
57bf74c
Compare
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@asuhan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #45157 +/- ##
==========================================
- Coverage 67.84% 67.83% -0.01%
==========================================
Files 384 384
Lines 50064 50064
==========================================
- Hits 33965 33962 -3
- Misses 16099 16102 +3
Continue to review full report at Codecov.
|
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
combineMultilane used the wrong order when ramp was on the left hand side,
which matters for subtract.
Test Plan:
test_tensorexpr --gtest_filter=TensorExprTest.SimplifyRampSubBroadcast