Skip to content

Conversation

@ansley
Copy link

@ansley ansley commented Sep 22, 2020

Stack from ghstack:

Differential Revision: D24078695

@ansley ansley requested a review from apaszke as a code owner September 22, 2020 18:37
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Sep 22, 2020
@dr-ci
Copy link

dr-ci bot commented Sep 22, 2020

💊 CI failures summary and remediations

As of commit ae25c1b (more details on the Dr. CI page):


Commit ae25c1b was recently pushed. Waiting for builds...


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 24 times.

ansley pushed a commit that referenced this pull request Sep 22, 2020
ghstack-source-id: ee3f1b5
Pull Request resolved: #45156
@ansley ansley requested a review from gmagogsfm September 23, 2020 00:10
ansley pushed a commit that referenced this pull request Sep 24, 2020
ghstack-source-id: 78db237
Pull Request resolved: #45156
ansley pushed a commit that referenced this pull request Sep 24, 2020
ghstack-source-id: d43b89d
Pull Request resolved: #45156
@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #45156 into gh/ansleyadelaide/5/base will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                    Coverage Diff                    @@
##           gh/ansleyadelaide/5/base   #45156   +/-   ##
=========================================================
  Coverage                     68.32%   68.32%           
=========================================================
  Files                           410      410           
  Lines                         52977    52977           
=========================================================
  Hits                          36194    36194           
  Misses                        16783    16783           
Impacted Files Coverage Δ
torch/onnx/__init__.py 86.95% <ø> (ø)
torch/onnx/utils.py 70.29% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a6b919...ae25c1b. Read the comment docs.

@ansley ansley linked an issue Sep 25, 2020 that may be closed by this pull request
@ansley ansley requested a review from gmagogsfm September 28, 2020 22:01
ansley pushed a commit that referenced this pull request Oct 1, 2020
ghstack-source-id: a130ba0
Pull Request resolved: #45156
ansley pushed a commit that referenced this pull request Oct 2, 2020
ghstack-source-id: d267cf9
Pull Request resolved: #45156
ansley pushed a commit that referenced this pull request Oct 2, 2020
ghstack-source-id: 6b02863
Pull Request resolved: #45156
ansley pushed a commit that referenced this pull request Oct 4, 2020
ghstack-source-id: ac8cf59
Pull Request resolved: #45156
@facebook-github-bot
Copy link
Contributor

@ansley merged this pull request in 5072728.

@ZolotukhinM
Copy link

Wow, nice, thanks for fixing that!

@facebook-github-bot facebook-github-bot deleted the gh/ansleyadelaide/5/head branch October 10, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JIT] Change the way strides are printed in types

5 participants