Fix preserve submodule attribute in freezing #45143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR prevents freezing cleaning up a submodule when user requests to preserve a submodule. [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
💊 CI failures summary and remediationsAs of commit 52d5f06 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚
1 failure confirmed as flaky and can be ignored:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 3 times. |
Codecov Report
@@ Coverage Diff @@
## gh/bzinodev/17/base #45143 +/- ##
=======================================================
- Coverage 67.84% 67.83% -0.01%
=======================================================
Files 384 384
Lines 50064 50064
=======================================================
- Hits 33965 33963 -2
- Misses 16099 16101 +2
Continue to review full report at Codecov.
|
eellison
approved these changes
Sep 23, 2020
| class TestModule(nn.Module): | ||
| def __init__(self): | ||
| super(TestModule, self).__init__() | ||
| self.sub1 = SubModule() # aliasing |
| m = TestModule() | ||
| ms = torch.jit.script(m) | ||
| ms.eval() | ||
| mf = torch._C._freeze_module(ms._c, ["sub1"]) |
Contributor
There was a problem hiding this comment.
nit: use public api torch.jit.freeze
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR prevents freezing cleaning up a submodule when user requests to
preserve a submodule.
Differential Revision: D23844969