Skip to content

[PyTorch] Enable type check for autocast_test_lists #45107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Hangjun wants to merge 1 commit into from
Closed

[PyTorch] Enable type check for autocast_test_lists #45107

Hangjun wants to merge 1 commit into from

Conversation

@Hangjun
Copy link

@Hangjun Hangjun commented Sep 22, 2020

Summary

This is a sub-task for addressing: #42969. We re-enable type check for autocast_test_lists .

Test Plan

python test/test_type_hints.py passed:

(pytorch) bash-5.0$ with-proxy python test/test_type_hints.py 
....
----------------------------------------------------------------------
Ran 4 tests in 103.871s

OK

@dr-ci
Copy link

dr-ci bot commented Sep 22, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit deac88a (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 7 times.

@codecov
Copy link

codecov bot commented Sep 22, 2020 •
edited
Loading

Codecov Report

Merging #45107 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #45107   +/-   ##
=======================================
  Coverage   67.85%   67.85%           
=======================================
  Files         384      384           
  Lines       50026    50026           
=======================================
+ Hits        33944    33947    +3     
+ Misses      16082    16079    -3
Impacted Files Coverage Δ
torch/testing/_internal/autocast_test_lists.py 13.51% <ø> (ø)
torch/testing/_internal/expecttest.py 78.57% <0.00%> (+1.02%) ⬆️
torch/utils/_benchmark/utils/common.py 79.33% <0.00%> (+1.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfc88d4...329769e. Read the comment docs.

@Hangjun Hangjun mentioned this pull request Sep 22, 2020
Closed
@Hangjun Hangjun requested a review from walterddr September 22, 2020 16:23
facebook-github-bot
facebook-github-bot reviewed Sep 22, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hangjun has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Hangjun Hangjun force-pushed the hangjunxu/enable-type-check-for-autocast_test_lists branch from 329769e to dc58e44 Compare September 22, 2020 18:53
facebook-github-bot
facebook-github-bot reviewed Sep 22, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hangjun has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Hangjun Hangjun force-pushed the hangjunxu/enable-type-check-for-autocast_test_lists branch from dc58e44 to deac88a Compare September 22, 2020 22:31
facebook-github-bot
facebook-github-bot reviewed Sep 22, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hangjun has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 23, 2020

@Hangjun merged this pull request in 35cdb01.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 23, 2020

@Hangjun merged this pull request in 35cdb01.

@facebook-github-bot facebook-github-bot deleted the hangjunxu/enable-type-check-for-autocast_test_lists branch January 27, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

+1 more reviewer

@walterddr walterddr walterddr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Hangjun @facebook-github-bot @walterddr @mruberry