Skip to content

Enabled torch.testing._internal.jit_utils.* typechecking. #44985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kauterry wants to merge 3 commits into from
Closed

Enabled torch.testing._internal.jit_utils.* typechecking. #44985

kauterry wants to merge 3 commits into from

Conversation

@kauterry
Copy link
Contributor

@kauterry kauterry commented Sep 18, 2020

Fixes #{issue number}

facebook-github-bot
facebook-github-bot reviewed Sep 18, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kauterry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dr-ci
Copy link

dr-ci bot commented Sep 18, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 6f0ab25 (more details on the Dr. CI page):

  • 2/4 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)
  • 2/4 broken upstream at merge base 374e937 on Sep 18 from 11:38am to 4:20pm PDT (13 commits; f175830 - 40c09cf)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_ge_config_simple_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Sep 20 01:29:52 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 20 01:29:52 At: 
Sep 20 01:29:52   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 20 01:29:52   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 20 01:29:52  
Sep 20 01:29:52 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 20 01:29:52  
Sep 20 01:29:52 At: 
Sep 20 01:29:52   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 20 01:29:52   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 20 01:29:52  
Sep 20 01:29:52 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 20 01:29:52  
Sep 20 01:29:52 At: 
Sep 20 01:29:52   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 20 01:29:52   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 20 01:29:52  
Sep 20 01:29:52 ok (1.541s) 
Sep 20 01:29:54   test_return_future_remote (__main__.ProcessGroupRpcTestWithSpawn) ... ok (1.539s) 
Sep 20 01:29:55   test_return_local_rrefs (__main__.ProcessGroupRpcTestWithSpawn) ... ok (1.541s) 
Sep 20 01:29:57   test_rpc_profiling_remote_record_function (__main__.ProcessGroupRpcTestWithSpawn) ... ERROR:root:Caught exception:  
Sep 20 01:29:57 Traceback (most recent call last):

🚧 2 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

Since your merge base is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 8 times.

@malfet malfet added module: typing Related to mypy type annotations triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Sep 18, 2020
walterddr
walterddr approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@walterddr walterddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks very great!

nit on the ordering of your function signatures.

@kauterry
Edited TODO for class FileCheck in torch/_C/__init__.pyi.in
6f0ab25 
Co-authored-by: Rong Rong <rongr@fb.com>
facebook-github-bot
facebook-github-bot reviewed Sep 19, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kauterry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Sep 21, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kauterry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 21, 2020

@kauterry merged this pull request in 4810365.

@facebook-github-bot facebook-github-bot deleted the krs/jit branch January 27, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@malfet malfet malfet approved these changes

+1 more reviewer

@walterddr walterddr walterddr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@walterddr walterddr

Labels

Merged module: typing Related to mypy type annotations triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kauterry @facebook-github-bot @malfet @walterddr @mruberry