Fix type hint warnings for common_methods_invocations.py #44971
Conversation
💊 CI failures summary and remediationsAs of commit a452038 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 13 times. |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@visweshfb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@visweshfb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@visweshfb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #44971 +/- ##
=========================================
Coverage ? 67.85%
=========================================
Files ? 384
Lines ? 50027
Branches ? 0
=========================================
Hits ? 33946
Misses ? 16081
Partials ? 0 Continue to review full report at Codecov.
|
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@visweshfb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@visweshfb merged this pull request in a4ce3f4. |
4 participants
Fixes a subtask of #42969
Tested the following and no warnings were seen.
python test/test_type_hints.py
....
Ran 4 tests in 180.759s
OK