[caffe2/aten] Fix clang build #44934
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D23775266 |
xw285cornell
force-pushed
the
export-D23775266
branch
from
775d1be to
7891cd0
Compare
Summary: Pull Request resolved: pytorch#44934 Fix build errors when using clang to build cuda sources: ``` In file included from aten/src/ATen/native/cuda/DistributionBernoulli.cu:4: In file included from aten/src/ATen/cuda/CUDAApplyUtils.cuh:5: caffe2/aten/src/THC/THCAtomics.cuh:321:1: error: control reaches end of non-void function [-Werror,-Wreturn-type] } ^ 1 error generated when compiling for sm_70. In file included from aten/src/ATen/native/cuda/DistributionBernoulli.cu:4: In file included from aten/src/ATen/cuda/CUDAApplyUtils.cuh:5: caffe2/aten/src/THC/THCAtomics.cuh:321:1: error: control reaches end of non-void function [-Werror,-Wreturn-type] } ^ 1 error generated when compiling for sm_60. In file included from aten/src/ATen/native/cuda/DistributionBernoulli.cu:4: In file included from aten/src/ATen/cuda/CUDAApplyUtils.cuh:5: caffe2/aten/src/THC/THCAtomics.cuh:321:1: error: control reaches end of non-void function [-Werror,-Wreturn-type] } ^ 1 error generated when compiling for sm_52. ``` Test Plan: CI Differential Revision: D23775266 fbshipit-source-id: 5fa4bf68c47b623c6dd51bd800c0334ed2ba34da
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D23775266 |
xw285cornell
force-pushed
the
export-D23775266
branch
from
7891cd0 to
0f48629
Compare
Codecov Report
@@ Coverage Diff @@
## master #44934 +/- ##
=======================================
Coverage 67.85% 67.86%
=======================================
Files 384 384
Lines 49948 49948
=======================================
+ Hits 33894 33895 +1
+ Misses 16054 16053 -1
Continue to review full report at Codecov.
|
Contributor
|
This pull request has been merged in 76a109c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix build errors when using clang to build cuda sources:
Test Plan: CI
Differential Revision: D23775266