-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[PyTorch] Enable type check for autocast_test_lists #44904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hangjun has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
walterddr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. thanks for the fix.
…ove-unused-cudaGetDevice-call
Codecov Report
@@ Coverage Diff @@
## master #44904 +/- ##
=======================================
Coverage 67.85% 67.85%
=======================================
Files 384 384
Lines 50026 50026
=======================================
Hits 33944 33944
Misses 16082 16082
Continue to review full report at Codecov.
|
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hangjun has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hangjun has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
💊 CI failures summary and remediationsAs of commit e004df2 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 5 times. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hangjun has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Moved to #45107. |
Summary
This is a sub-task for addressing: #42969. We re-enable type check for
autocast_test_lists.Test Plan
python test/test_type_hints.pypassed.