Fix handling of empty indices in CUDA Tensor.put_ #4486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumith
approved these changes
Jan 4, 2018
apaszke
reviewed
Jan 5, 2018
|
|
||
| int srcDims = THCTensor_(nDimension)(state, src); | ||
| THArgCheck(srcDims > 0, 2, "Source tensor is empty"); | ||
| if (THCTensor_(numel)(state, src) == 0) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
gchanan
approved these changes
Jan 5, 2018
Contributor
gchanan
left a comment
gchanan
left a comment
There was a problem hiding this comment.
would be nice to eventually move these functions to ATen native; The dispatch code should handle empty tensors and scalars correctly and you only need to write the error checking once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4386