Skip to content

[quant] Fix ConvTranspose mapping #44844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
z-a-f wants to merge 3 commits into from
Closed

[quant] Fix ConvTranspose mapping #44844

z-a-f wants to merge 3 commits into from

Conversation

@z-a-f
Copy link

@z-a-f z-a-f commented Sep 16, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D23746466

@z-a-f z-a-f mentioned this pull request Sep 16, 2020
Merged
@z-a-f z-a-f requested a review from jerryzh168 September 16, 2020 23:01
@codecov
Copy link

codecov bot commented Sep 17, 2020 •
edited
Loading

Codecov Report

Merging #44844 into gh/z-a-f/62/base will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           gh/z-a-f/62/base   #44844      +/-   ##
====================================================
+ Coverage             67.89%   68.08%   +0.19%     
====================================================
  Files                   384      384              
  Lines                 49873    49774      -99     
====================================================
+ Hits                  33861    33889      +28     
+ Misses                16012    15885     -127
Impacted Files Coverage Δ
torch/quantization/quantization_mappings.py 85.10% <ø> (ø)
torch/quantization/quantize_fx.py 94.33% <0.00%> (-3.78%) ⬇️
torch/distributed/rpc/api.py 30.69% <0.00%> (-0.38%) ⬇️
...rch/testing/_internal/jit_metaprogramming_utils.py 52.71% <0.00%> (-0.26%) ⬇️
torch/_jit_internal.py 93.35% <0.00%> (-0.15%) ⬇️
...orch/testing/_internal/distributed/rpc/rpc_test.py 25.68% <0.00%> (-0.01%) ⬇️
torch/onnx/utils.py 72.06% <0.00%> (ø)
torch/utils/dlpack.py 100.00% <0.00%> (ø)
torch/nn/utils/fusion.py 100.00% <0.00%> (ø)
torch/distributed/launch.py 0.00% <0.00%> (ø)
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f22b1...ee6a3f1. Read the comment docs.

@z-a-f z-a-f mentioned this pull request Sep 21, 2020
Closed
@dr-ci
Copy link

dr-ci bot commented Sep 21, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit ee6a3f1 (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)

XLA failure

Job pytorch_xla_linux_bionic_py3_6_clang9_build is failing. Please create an issue with title prefixed by [PT_BREAK] in pytorch/xla and link to to this PR. If you have questions, please reach out to @ailzhang / @dlibenzi / @JackCaoG.

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 22, 2020

@z-a-f merged this pull request in 2b1f258.

@facebook-github-bot facebook-github-bot deleted the gh/z-a-f/62/head branch September 26, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@z-a-f @facebook-github-bot @jerryzh168 @mruberry