Skip to content

CUDA BFloat activations 1 #44834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zasdfgbnm wants to merge 4 commits into from
Closed

CUDA BFloat activations 1 #44834

zasdfgbnm wants to merge 4 commits into from

Conversation

@zasdfgbnm
Copy link
Collaborator

@zasdfgbnm zasdfgbnm commented Sep 16, 2020

No description provided.

@dr-ci
Copy link

dr-ci bot commented Sep 16, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 28ae28c (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 12 times.

@mruberry mruberry added module: cuda Related to torch.cuda, and CUDA support in general triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Sep 17, 2020
@mruberry mruberry requested a review from ngimel September 17, 2020 03:15
@ngimel
Copy link
Collaborator

ngimel commented Sep 17, 2020

Do you think test error is related? Can you rebase and see if it goes away?

@zasdfgbnm
Copy link
Collaborator Author

zasdfgbnm commented Sep 17, 2020

rebased

@ngimel
Copy link
Collaborator

ngimel commented Sep 17, 2020

Yeah, turns out this test is broken now.

facebook-github-bot
facebook-github-bot reviewed Sep 17, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ngimel
Copy link
Collaborator

ngimel commented Sep 17, 2020

Sorry, can you please rebase again to get signal from cuda tests? Yesterday's breakage is fixed.

@zasdfgbnm
Copy link
Collaborator Author

zasdfgbnm commented Sep 17, 2020

rebased

@codecov
Copy link

codecov bot commented Sep 17, 2020 •
edited
Loading

Codecov Report

Merging #44834 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #44834      +/-   ##
==========================================
- Coverage   67.89%   67.89%   -0.01%     
==========================================
  Files         384      384              
  Lines       49879    49879              
==========================================
- Hits        33864    33863       -1     
- Misses      16015    16016       +1
Impacted Files Coverage Δ
torch/testing/_internal/expecttest.py 77.55% <0.00%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74c3dcd...28ae28c. Read the comment docs.

@zasdfgbnm zasdfgbnm deleted the bfloat-activations branch September 18, 2020 22:54
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 19, 2020

@ngimel merged this pull request in 0638940.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

Merged module: bfloat16 module: cuda Related to torch.cuda, and CUDA support in general open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zasdfgbnm @ngimel @facebook-github-bot @pytorchbot @mruberry