Skip to content

Enable type check for torch.testing._internal.dist_utils.* #44832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
samestep wants to merge 2 commits into from
Closed

Enable type check for torch.testing._internal.dist_utils.* #44832

samestep wants to merge 2 commits into from

Conversation

@samestep
Copy link
Contributor

@samestep samestep commented Sep 16, 2020

Addresses a sub-task of #44752.

@samestep samestep added the module: typing Related to mypy type annotations label Sep 16, 2020
facebook-github-bot
facebook-github-bot reviewed Sep 16, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@malfet malfet self-requested a review September 16, 2020 22:00
@dr-ci
Copy link

dr-ci bot commented Sep 16, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 627d743 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_linux_bionic_py3_6_clang9_test (1/1)

Step: "Report results" (full log | diagnosis details | 🔁 rerun) ❄️

Sep 17 18:22:50 ConnectionResetError: [Errno 104] Connection reset by peer 
Sep 17 18:22:50   File "/opt/conda/lib/python3.6/http/client.py", line 1081, in _send_output 
Sep 17 18:22:50     self.send(chunk) 
Sep 17 18:22:50   File "/opt/conda/lib/python3.6/http/client.py", line 1002, in send 
Sep 17 18:22:50     self.sock.sendall(data) 
Sep 17 18:22:50   File "/opt/conda/lib/python3.6/ssl.py", line 975, in sendall 
Sep 17 18:22:50     v = self.send(byte_view[count:]) 
Sep 17 18:22:50   File "/opt/conda/lib/python3.6/ssl.py", line 944, in send 
Sep 17 18:22:50     return self._sslobj.write(data) 
Sep 17 18:22:50   File "/opt/conda/lib/python3.6/ssl.py", line 642, in write 
Sep 17 18:22:50     return self._sslobj.write(data) 
Sep 17 18:22:50 ConnectionResetError: [Errno 104] Connection reset by peer 
Sep 17 18:22:50  
Sep 17 18:22:50 During handling of the above exception, another exception occurred: 
Sep 17 18:22:50  
Sep 17 18:22:50 Traceback (most recent call last): 
Sep 17 18:22:50   File "/opt/conda/lib/python3.6/site-packages/requests/adapters.py", line 449, in send 
Sep 17 18:22:50     timeout=timeout 
Sep 17 18:22:50   File "/opt/conda/lib/python3.6/site-packages/urllib3/connectionpool.py", line 727, in urlopen 
Sep 17 18:22:50     method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2] 
Sep 17 18:22:50   File "/opt/conda/lib/python3.6/site-packages/urllib3/util/retry.py", line 403, in increment 
Sep 17 18:22:50     raise six.reraise(type(error), error, _stacktrace)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 14 times.

@samestep samestep force-pushed the typecheck-dist-utils branch from 4395c73 to 6eb03d0 Compare September 17, 2020 15:12
@samestep samestep force-pushed the typecheck-dist-utils branch from 6eb03d0 to 9a14d9b Compare September 17, 2020 15:39
walterddr
walterddr reviewed Sep 17, 2020
View reviewed changes
walterddr
walterddr reviewed Sep 17, 2020
View reviewed changes
Copy link
Contributor

@walterddr walterddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @samestep

@malfet actually seems like _rref_context_get_debug_info is defined under torch/csrc/distributed/rpc/init.cpp
was not sure if we should start importing these to - for example torch._C._distributed.pyi.in ?

@samestep
Update torch/testing/_internal/dist_utils.py
627d743 
Co-authored-by: Rong Rong <rongr@fb.com>
@samestep samestep force-pushed the typecheck-dist-utils branch from 6172f0c to 627d743 Compare September 17, 2020 16:31
facebook-github-bot
facebook-github-bot reviewed Sep 17, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 18, 2020

@samestep merged this pull request in c2cf6ef.

@facebook-github-bot facebook-github-bot deleted the typecheck-dist-utils branch January 27, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@malfet malfet malfet approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@pietern pietern Awaiting requested review from pietern

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

+1 more reviewer

@walterddr walterddr walterddr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged module: typing Related to mypy type annotations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@samestep @facebook-github-bot @malfet @walterddr @mruberry