Skip to content

CUDA BFloat16 unary ops part 1 #44813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zasdfgbnm wants to merge 6 commits into from
Closed

CUDA BFloat16 unary ops part 1 #44813

zasdfgbnm wants to merge 6 commits into from

Conversation

@zasdfgbnm
Copy link
Collaborator

@zasdfgbnm zasdfgbnm commented Sep 16, 2020

No description provided.

@dr-ci
Copy link

dr-ci bot commented Sep 16, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit b95ad1d (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

XLA failure

Job pytorch_xla_linux_bionic_py3_6_clang9_test is failing. Please create an issue with title prefixed by [PT_BREAK] in pytorch/xla and link to to this PR. If you have questions, please reach out to @ailzhang / @dlibenzi / @JackCaoG.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 19 times.

@zasdfgbnm zasdfgbnm requested a review from ngimel September 16, 2020 21:34
@mruberry mruberry added module: cuda Related to torch.cuda, and CUDA support in general module: bfloat16 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Sep 17, 2020
@ngimel
Copy link
Collaborator

ngimel commented Sep 17, 2020

Test errors are real

@ngimel
Copy link
Collaborator

ngimel commented Sep 17, 2020

You need to adjust dtypesIfCUDA here https://github.com/pytorch/pytorch/blob/master/torch/testing/_internal/common_methods_invocations.py#L233 and in similar places.

@ngimel
Copy link
Collaborator

ngimel commented Sep 17, 2020

Now flake import error is real :-)

@zasdfgbnm zasdfgbnm mentioned this pull request Sep 18, 2020
Closed
@ngimel
Copy link
Collaborator

ngimel commented Sep 18, 2020

Is XLA fixing those operators, or skipping tests on their side? Let me know when this is ready.

@JackCaoG
Copy link
Collaborator

JackCaoG commented Sep 18, 2020

I submit a fix on xla side(lowering for these ops) in pytorch/xla#2501

facebook-github-bot
facebook-github-bot reviewed Sep 20, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zasdfgbnm zasdfgbnm deleted the bfloat-unary1 branch September 21, 2020 21:52
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 21, 2020

@ngimel merged this pull request in 581a364.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

Merged module: bfloat16 module: cuda Related to torch.cuda, and CUDA support in general open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zasdfgbnm @ngimel @JackCaoG @facebook-github-bot @pytorchbot @mruberry