Skip to content

Enable typechecking for torch.testing._internal.common_quantized.* #44805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
janeyx99 wants to merge 4 commits into from
Closed

Enable typechecking for torch.testing._internal.common_quantized.* #44805

janeyx99 wants to merge 4 commits into from

Conversation

@janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Sep 16, 2020

Addresses a subproblem of Issue 42969

@dr-ci
Copy link

dr-ci bot commented Sep 16, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 3dc7ee2 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 15 times.

facebook-github-bot
facebook-github-bot reviewed Sep 16, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janeyx99 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@malfet malfet self-requested a review September 16, 2020 22:01
facebook-github-bot
facebook-github-bot reviewed Sep 17, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janeyx99 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Sep 17, 2020 •
edited
Loading

Codecov Report

Merging #44805 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #44805      +/-   ##
==========================================
- Coverage   67.89%   67.89%   -0.01%     
==========================================
  Files         384      384              
  Lines       49879    49881       +2     
==========================================
- Hits        33866    33865       -1     
- Misses      16013    16016       +3
Impacted Files Coverage Δ
torch/backends/quantized/__init__.py 92.30% <100.00%> (+0.41%) ⬆️
torch/utils/_benchmark/utils/common.py 77.68% <0.00%> (-2.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4affbbd...3dc7ee2. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 17, 2020

@janeyx99 merged this pull request in 1c996b7.

xuzhao9 pushed a commit that referenced this pull request Sep 18, 2020
@janeyx99 @xuzhao9
Enable typechecking for torch.testing._internal.common_quantized.* (#…
23b93da 
…44805)

Summary:
Addresses a subproblem of [Issue 42969](#42969)

Pull Request resolved: #44805

Reviewed By: malfet

Differential Revision: D23742754

Pulled By: janeyx99

fbshipit-source-id: e916a6a0c049cac318549a485d47f19363087d15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@janeyx99 @facebook-github-bot @malfet @mruberry