CUDA BFloat16 and other improvements on abs #44804
Conversation
💊 CI failures summary and remediationsAs of commit 7fc2e19 (more details on the Dr. CI page):
1 job timed out:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 12 times. |
|
Tests are passing, now ROCm supports |
Codecov Report
@@ Coverage Diff @@
## master #44804 +/- ##
=======================================
Coverage 68.04% 68.05%
=======================================
Files 384 384
Lines 49814 49814
=======================================
+ Hits 33897 33899 +2
+ Misses 15917 15915 -2
Continue to review full report at Codecov.
|
| return abs_wrapper(a); | ||
| }); | ||
| gpu_kernel(iter, []GPU_LAMBDA(scalar_t a) -> scalar_t { | ||
| return abs_wrapper(a); |
There was a problem hiding this comment.
do you need abs_wrapper now, or can it just be std::abs here?
There was a problem hiding this comment.
Looks like the special cast of bool and uint8_t is not needed as well.
There was a problem hiding this comment.
I have updated this PR.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Not sure if ROCm supports `std::abs` today, let's see the CI Pull Request resolved: #44804 Reviewed By: mruberry Differential Revision: D23748837 Pulled By: ngimel fbshipit-source-id: ccf4e63279f3e5927a85d8d8f70ba4b8c334156b
Not sure if ROCm supports
std::abstoday, let's see the CI