Skip to content

CUDA BFloat div, addcdiv, addcmul, mean, var #44758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zasdfgbnm wants to merge 3 commits into from
Closed

CUDA BFloat div, addcdiv, addcmul, mean, var #44758

zasdfgbnm wants to merge 3 commits into from

Conversation

@zasdfgbnm
Copy link
Collaborator

@zasdfgbnm zasdfgbnm commented Sep 15, 2020

No description provided.

@dr-ci
Copy link

dr-ci bot commented Sep 15, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit d74132a (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_ge_config_simple_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Sep 18 03:39:38 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 18 03:39:38 At: 
Sep 18 03:39:38   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 18 03:39:38   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 18 03:39:38  
Sep 18 03:39:38 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 18 03:39:38  
Sep 18 03:39:38 At: 
Sep 18 03:39:38   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 18 03:39:38   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 18 03:39:38  
Sep 18 03:39:38 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 18 03:39:38  
Sep 18 03:39:38 At: 
Sep 18 03:39:38   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 18 03:39:38   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 18 03:39:38  
Sep 18 03:39:38 ok (1.639s) 
Sep 18 03:39:39   test_return_future_remote (__main__.TensorPipeRpcTestWithSpawn) ... [W tensorpipe_agent.cpp:576] RPC agent for worker0 encountered error when reading incoming request from worker3: EOF: end of file (this is expected to happen during shutdown) 
Sep 18 03:39:39 [W tensorpipe_agent.cpp:576] RPC agent for worker0 encountered error when reading incoming request from worker2: EOF: end of file (this is expected to happen during shutdown) 
Sep 18 03:39:40 ok (1.636s) 
Sep 18 03:39:41   test_return_local_rrefs (__main__.TensorPipeRpcTestWithSpawn) ... [W tensorpipe_agent.cpp:576] RPC agent for worker2 encountered error when reading incoming request from worker3: EOF: end of file (this is expected to happen during shutdown)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 5 times.

@ngimel ngimel self-requested a review September 16, 2020 03:19
@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 16, 2020
@zasdfgbnm zasdfgbnm mentioned this pull request Sep 16, 2020
Closed
facebook-github-bot
facebook-github-bot reviewed Sep 17, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ngimel
Copy link
Collaborator

ngimel commented Sep 17, 2020

xla error is real, let me know what you want to do about it?

@zasdfgbnm
Copy link
Collaborator Author

zasdfgbnm commented Sep 17, 2020

@ngimel There is already a PR pytorch/xla#2495 fixing this

@zasdfgbnm
Copy link
Collaborator Author

zasdfgbnm commented Sep 18, 2020

XLA test is fixed

facebook-github-bot
facebook-github-bot reviewed Sep 18, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zasdfgbnm zasdfgbnm deleted the bfloat-elementwise-reductions branch September 18, 2020 18:56
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 18, 2020

@ngimel merged this pull request in 7bd8a69.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zasdfgbnm @ngimel @facebook-github-bot @pytorchbot @mruberry