Skip to content

CUDA BFloat16 i0 support #44750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zasdfgbnm wants to merge 2 commits into from
Closed

CUDA BFloat16 i0 support #44750

zasdfgbnm wants to merge 2 commits into from

Conversation

@zasdfgbnm
Copy link
Collaborator

@zasdfgbnm zasdfgbnm commented Sep 15, 2020

No description provided.

@dr-ci
Copy link

dr-ci bot commented Sep 16, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 87b1623 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

2 failures confirmed as flaky and can be ignored:

  • pytorch_windows_vs2019_py36_cpu_build
  • pytorch_windows_vs2019_py36_cuda10.1_build

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 9 times.

@ngimel
Copy link
Collaborator

ngimel commented Sep 16, 2020

Test error is real

@zasdfgbnm
Copy link
Collaborator Author

zasdfgbnm commented Sep 16, 2020

@ngimel Yeah, I actually need #44748 so that the test for ne does not assertRaise

@zasdfgbnm
Copy link
Collaborator Author

zasdfgbnm commented Sep 16, 2020

Rebased, should be working

@codecov
Copy link

codecov bot commented Sep 16, 2020 •
edited
Loading

Codecov Report

Merging #44750 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #44750   +/-   ##
=======================================
  Coverage   68.04%   68.05%           
=======================================
  Files         384      384           
  Lines       49814    49814           
=======================================
+ Hits        33897    33899    +2     
+ Misses      15917    15915    -2
Impacted Files Coverage Δ
torch/utils/_benchmark/utils/common.py 79.33% <0.00%> (+1.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a011b86...87b1623. Read the comment docs.

@zasdfgbnm
Copy link
Collaborator Author

zasdfgbnm commented Sep 17, 2020

ROCm failure is unrelated:

19:18:41 test_conv_transposed_large_cpu (__main__.TestNNDeviceTypeCPU) ... Traceback (most recent call last):
19:19:13   File "test/run_test.py", line 741, in <module>
19:19:13     main()
19:19:13   File "test/run_test.py", line 724, in main
19:19:13     raise RuntimeError(err_message)
19:19:13 RuntimeError: test_nn failed! Received signal: SIGBUS

facebook-github-bot
facebook-github-bot reviewed Sep 17, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zasdfgbnm zasdfgbnm deleted the bfloat-i0 branch September 17, 2020 21:08
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 17, 2020

@ngimel merged this pull request in f5440a4.

xuzhao9 pushed a commit that referenced this pull request Sep 18, 2020
@zasdfgbnm @xuzhao9
CUDA BFloat16 i0 support (#44750)
d37d234 
Summary: Pull Request resolved: #44750

Reviewed By: glaringlee

Differential Revision: D23764383

Pulled By: ngimel

fbshipit-source-id: d0e784d89241e8028f97766fdac51fe1ab4c188c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zasdfgbnm @ngimel @facebook-github-bot @pytorchbot @mruberry