Skip to content

Conversation

@mcarilli
Copy link
Collaborator

@mcarilli mcarilli commented Sep 15, 2020

https://pytorch.org/tutorials/recipes/recipes/amp_recipe.html is live. Core amp docs should reference it.

Also i fixed some typos in the zero_grad docs we ignored when git was behaving weirdly during @ngimel 's merge of #44423.

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #44725 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #44725   +/-   ##
=======================================
  Coverage   67.95%   67.95%           
=======================================
  Files         384      384           
  Lines       49763    49763           
=======================================
  Hits        33817    33817           
  Misses      15946    15946           
Impacted Files Coverage Δ
torch/nn/modules/module.py 92.41% <ø> (ø)
torch/optim/optimizer.py 88.52% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7036e91...f591406. Read the comment docs.

@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 16, 2020
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in 3e6bb52.

xuzhao9 pushed a commit that referenced this pull request Sep 18, 2020
Summary:
https://pytorch.org/tutorials/recipes/recipes/amp_recipe.html is live.  Core amp docs should reference it.

Also i fixed some typos in the `zero_grad` docs we ignored when git was behaving weirdly during ngimel 's merge of #44423.

Pull Request resolved: #44725

Reviewed By: mruberry

Differential Revision: D23723807

Pulled By: ngimel

fbshipit-source-id: ca0b76365f8ca908bd978e3b38bf81857fa6c2a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants