Vectorize complex copy. #44722
Closed
Vectorize complex copy. #44722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit b364e08 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 6 times. |
Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
anjali411
reviewed
Sep 15, 2020
| iter, | ||
| [=](scalar_t a) -> scalar_t { return a; }); | ||
| [=](scalar_t a) -> scalar_t { return a; }, | ||
| [=](Vec256<scalar_t> a) -> Vec256<scalar_t> { return a; }); |
Contributor
There was a problem hiding this comment.
wow didn't realize we were not vectorizing copy for complex. thanks for the PR!
anjali411
approved these changes
Sep 15, 2020
Codecov Report
@@ Coverage Diff @@
## gh/ezyang/838/base #44722 +/- ##
===================================================
Coverage 67.92% 67.92%
===================================================
Files 384 384
Lines 49727 49727
===================================================
+ Hits 33777 33779 +2
+ Misses 15950 15948 -2
Continue to review full report at Codecov.
|
Closed
Contributor
xuzhao9
pushed a commit
that referenced
this pull request
Sep 18, 2020
Summary: Pull Request resolved: #44722 Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: anjali411 Differential Revision: D23731276 Pulled By: ezyang fbshipit-source-id: 4902c4b79577ae3c70aca94828006b12914ab7f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D23731276