Skip to content

Mention TF32 on related docs #44690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zasdfgbnm wants to merge 6 commits into from
Closed

Mention TF32 on related docs #44690

zasdfgbnm wants to merge 6 commits into from

Conversation

@zasdfgbnm
Copy link
Collaborator

@zasdfgbnm zasdfgbnm commented Sep 15, 2020 •
edited
Loading

cc: @ptrblck

image

@zasdfgbnm zasdfgbnm requested a review from apaszke as a code owner September 15, 2020 05:04
@zasdfgbnm zasdfgbnm requested a review from mcarilli September 15, 2020 05:05
mcarilli
mcarilli reviewed Sep 15, 2020
View reviewed changes
docs/source/backends.rst Outdated
available on Ampere or newer GPUs that allows speeding up certain computations at the
cost of precision.

See :ref:`tf32_on_ampere` for more information.
Copy link
Collaborator

@mcarilli mcarilli Sep 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this display the hidden link tag tf32_on_ampere directly on the rendered page, or will it display the full title of the target (TensorFloat-32(TF32) on Ampere devices)? If it displays the full target title I think that's alright.

If you want to set the displayed text to something shorter, this is the syntax, maybe you already know.

:ref:`Displayed Text<tf32_on_ampere>`

Copy link
Collaborator Author

@zasdfgbnm zasdfgbnm Sep 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the full title:
image

But thank you for letting me know the

:ref:`Displayed Text<tf32_on_ampere>`

I didn't know there is a way to specify the text.

@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 15, 2020
@dr-ci
Copy link

dr-ci bot commented Sep 15, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit a103696 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 7 times.

@mruberry mruberry removed the request for review from apaszke September 15, 2020 09:38
mruberry
mruberry reviewed Sep 15, 2020
View reviewed changes
mruberry
mruberry reviewed Sep 15, 2020
View reviewed changes
mruberry
mruberry reviewed Sep 15, 2020
View reviewed changes
mruberry
mruberry reviewed Sep 15, 2020
View reviewed changes
mruberry
mruberry reviewed Sep 15, 2020
View reviewed changes
mruberry
mruberry reviewed Sep 15, 2020
View reviewed changes
mruberry
mruberry reviewed Sep 15, 2020
View reviewed changes
mruberry
mruberry reviewed Sep 15, 2020
View reviewed changes
@codecov
Copy link

codecov bot commented Sep 16, 2020 •
edited
Loading

Codecov Report

Merging #44690 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #44690   +/-   ##
=======================================
  Coverage   67.97%   67.97%           
=======================================
  Files         384      384           
  Lines       49626    49627    +1     
=======================================
+ Hits        33731    33733    +2     
+ Misses      15895    15894    -1
Impacted Files Coverage Δ
torch/backends/cudnn/__init__.py 59.74% <ø> (ø)
torch/nn/functional.py 92.17% <ø> (ø)
torch/nn/modules/conv.py 95.69% <ø> (ø)
torch/nn/modules/linear.py 98.46% <ø> (ø)
torch/_torch_docs.py 100.00% <100.00%> (ø)
torch/testing/_internal/expecttest.py 77.55% <0.00%> (-1.03%) ⬇️
torch/utils/_benchmark/utils/common.py 79.33% <0.00%> (+1.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ace81b6...a103696. Read the comment docs.

@mruberry
Copy link
Collaborator

mruberry commented Sep 16, 2020

Thanks @zasdfgbnm!

facebook-github-bot
facebook-github-bot reviewed Sep 16, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zasdfgbnm zasdfgbnm deleted the tf32-docs branch September 17, 2020 02:33
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 17, 2020

@mruberry merged this pull request in e48201c.

xuzhao9 pushed a commit that referenced this pull request Sep 18, 2020
@zasdfgbnm @xuzhao9
Mention TF32 on related docs (#44690)
e08ccd1 
Summary:
cc: ptrblck

![image](https://user-images.githubusercontent.com/1032377/93168022-cbbfcb80-f6d6-11ea-8f6e-f2c8a15c5bea.png)

Pull Request resolved: #44690

Reviewed By: ngimel

Differential Revision: D23727921

Pulled By: mruberry

fbshipit-source-id: db7cc8e74cde09c13d6a57683129fd839863b914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@mcarilli mcarilli mcarilli left review comments

@mruberry mruberry mruberry approved these changes

@ngimel ngimel Awaiting requested review from ngimel

Assignees

No one assigned

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zasdfgbnm @mruberry @facebook-github-bot @mcarilli @ngimel @pytorchbot