fixes lda condition for blas functions, fixes bug with beta=0 in addmv slow path #44681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasdfgbnm
reviewed
Sep 15, 2020
test/test_torch.py
Outdated
| v = torch.randn(100, device=device).to(dtype) | ||
| self._test_addmm_addmv(torch.addmv, t, m, v, beta=0) | ||
|
|
||
| # Test beta=0, v=nan, 0-strided v |
Collaborator
There was a problem hiding this comment.
Suggested change
| # Test beta=0, v=nan, 0-strided v | |
| # Test beta=0, t=nan, 0-strided v |
zasdfgbnm
reviewed
Sep 15, 2020
Collaborator
Author
|
Tests expanded according to @zasdfgbnm suggestion (thanks!), initialization for broadcasted matrices/vectors in tests fixed to remain within exactly representable numbers and reduce errors |
zasdfgbnm
approved these changes
Sep 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #44681 +/- ##
=======================================
Coverage 67.97% 67.97%
=======================================
Files 384 384
Lines 49626 49626
=======================================
Hits 33731 33731
Misses 15895 15895 Continue to review full report at Codecov.
|
mruberry
reviewed
Sep 15, 2020
mruberry
reviewed
Sep 15, 2020
mruberry
reviewed
Sep 15, 2020
mruberry
approved these changes
Sep 15, 2020
Collaborator
mruberry
left a comment
mruberry
left a comment
There was a problem hiding this comment.
Maybe we can have nice things after all.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
💊 CI failures summary and remediationsAs of commit 324f2a9 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This was referenced Sep 15, 2020
zou3519
approved these changes
Sep 16, 2020
Contributor
xuzhao9
pushed a commit
that referenced
this pull request
Sep 18, 2020
…v slow path (#44681) Summary: per title. If `beta=0` and slow path was taken, `nan` and `inf` in the result were not masked as is the case with other linear algebra functions. Similarly, since `mv` is implemented as `addmv` with `beta=0`, wrong results were sometimes produced for `mv` slow path. Pull Request resolved: #44681 Reviewed By: mruberry Differential Revision: D23708653 Pulled By: ngimel fbshipit-source-id: e2d5d3e6f69b194eb29b327e1c6f70035f3b231c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per title. If
beta=0and slow path was taken,nanandinfin the result were not masked as is the case with other linear algebra functions. Similarly, sincemvis implemented asaddmvwithbeta=0, wrong results were sometimes produced formvslow path.