qat conv_fused.py: one more patch for forward compatibility #44671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: See comments inline - the FC between pytorch#38478 and pytorch#38820 was broken, patching it. Test Plan: Verified with customer hitting the issue that this fixes their issue. Differential Revision: D23694029 fbshipit-source-id: 33cbfcbe6d9f2bcd5bcafe4aded81a80fc493e6a
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D23694029 |
Codecov Report
@@ Coverage Diff @@
## master #44671 +/- ##
==========================================
- Coverage 67.93% 67.93% -0.01%
==========================================
Files 384 384
Lines 49746 49748 +2
==========================================
Hits 33797 33797
- Misses 15949 15951 +2
Continue to review full report at Codecov.
|
💊 CI failures summary and remediationsAs of commit 29069d8 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
codecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
jerryzh168
approved these changes
Sep 15, 2020
Contributor
|
This pull request has been merged in 5f692a6. |
xuzhao9
pushed a commit
that referenced
this pull request
Sep 18, 2020
Summary: Pull Request resolved: #44671 See comments inline - the FC between #38478 and #38820 was broken, patching it. Test Plan: Verified with customer hitting the issue that this fixes their issue. Reviewed By: jerryzh168 Differential Revision: D23694029 fbshipit-source-id: a5e1733334e22305a111df750b190776889705d0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See comments inline - the FC between
#38478 and
#38820 was broken,
patching it.
Test Plan: Verified with customer hitting the issue that this fixes their issue.
Differential Revision: D23694029