Make async_execution compatible with RRef helpers #44666
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
mrshenli
requested review from
pritamdamania87 and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit e7989ef (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 18 times. |
Differential Revision: [D23691989](https://our.internmc.facebook.com/intern/diff/D23691989) [ghstack-poisoned]
This commit uses the `RRef._get_type()` to check whether the given function is decorated with `async_execution` and then calls the corresponding RPC target function. Differential Revision: [D23691989](https://our.internmc.facebook.com/intern/diff/D23691989) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/mrshenli/237/base #44666 +/- ##
=======================================================
Coverage ? 67.88%
=======================================================
Files ? 384
Lines ? 49715
Branches ? 0
=======================================================
Hits ? 33751
Misses ? 15964
Partials ? 0 Continue to review full report at Codecov.
|
This commit uses the `RRef._get_type()` to check whether the given function is decorated with `async_execution` and then calls the corresponding RPC target function. Differential Revision: [D23691989](https://our.internmc.facebook.com/intern/diff/D23691989) [ghstack-poisoned]
This commit uses the `RRef._get_type()` to check whether the given function is decorated with `async_execution` and then calls the corresponding RPC target function. Differential Revision: [D23691989](https://our.internmc.facebook.com/intern/diff/D23691989) [ghstack-poisoned]
This commit uses the `RRef._get_type()` to check whether the given function is decorated with `async_execution` and then calls the corresponding RPC target function. Differential Revision: [D23691989](https://our.internmc.facebook.com/intern/diff/D23691989) [ghstack-poisoned]
This commit uses the `RRef._get_type()` to check whether the given function is decorated with `async_execution` and then calls the corresponding RPC target function. Differential Revision: [D23691989](https://our.internmc.facebook.com/intern/diff/D23691989) [ghstack-poisoned]
Contributor
xuzhao9
pushed a commit
that referenced
this pull request
Sep 18, 2020
Summary: Pull Request resolved: #44666 Test Plan: Imported from OSS Reviewed By: rohan-varma Differential Revision: D23691989 Pulled By: mrshenli fbshipit-source-id: b36f4b1c9d7782797a0220434a8272610a23e83e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This commit uses the
RRef._get_type()to check whether thegiven function is decorated with
async_executionand thencalls the corresponding RPC target function.
Differential Revision: D23691989