Skip to content

Add batching rule for "is_complex", "conj" #44649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zou3519 wants to merge 5 commits into from
Closed

Add batching rule for "is_complex", "conj" #44649

zou3519 wants to merge 5 commits into from

Conversation

@zou3519
Copy link
Contributor

@zou3519 zou3519 commented Sep 14, 2020 •
edited
Loading

Stack from ghstack:

To unblock #43208, which adds "is_complex" checks to backward formulas
that are being tested for batched gradient support with vmap.

Test Plan:

  • pytest test/test_vmap.py -v

Differential Revision: D23685356

@zou3519
Add batching rule for "is_complex", "conj"
9e33170 
To unblock #43208, which adds "is_complex" checks to backward formulas
that are being tested for batched gradient support with vmap.

Test Plan:
- `pytest test/test_vmap.py -v`

[ghstack-poisoned]
@zou3519 zou3519 mentioned this pull request Sep 14, 2020
Closed
@zou3519
Update on "Add batching rule for "is_complex", "conj""
18ffdf4 
To unblock #43208, which adds "is_complex" checks to backward formulas
that are being tested for batched gradient support with vmap.

Test Plan:
- `pytest test/test_vmap.py -v`

Differential Revision: [D23685356](https://our.internmc.facebook.com/intern/diff/D23685356)

[ghstack-poisoned]
anjali411
anjali411 reviewed Sep 14, 2020
View reviewed changes
Copy link
Contributor

@anjali411 anjali411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like test_vmap is not added in this list https://github.com/pytorch/pytorch/blob/master/test/run_test.py and that's why (despite the test failures), the CI was green for #43208

@zou3519
Copy link
Contributor Author

zou3519 commented Sep 14, 2020

Looks like test_vmap is not added in this list https://github.com/pytorch/pytorch/blob/master/test/run_test.py and that's why (despite the test failures), the CI was green for #43208

Thanks for pointing that out. I've added it to run_test in #44656. Fingers crossed that there are no Windows or rocm issues...

@zou3519
Update on "Add batching rule for "is_complex", "conj""
eb3a452 
To unblock #43208, which adds "is_complex" checks to backward formulas
that are being tested for batched gradient support with vmap.

Test Plan:
- `pytest test/test_vmap.py -v`

Differential Revision: [D23685356](https://our.internmc.facebook.com/intern/diff/D23685356)

[ghstack-poisoned]
zou3519 added a commit that referenced this pull request Sep 14, 2020
@zou3519
Add batching rule for "is_complex", "conj"
af190d5 
To unblock #43208, which adds "is_complex" checks to backward formulas
that are being tested for batched gradient support with vmap.

Test Plan:
- `pytest test/test_vmap.py -v`

ghstack-source-id: 532bf14
Pull Request resolved: #44649
@dr-ci
Copy link

dr-ci bot commented Sep 14, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit b3442a4 (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)

1 job timed out:

  • pytorch_linux_xenial_py3_clang5_asan_test2

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 7 times.

@codecov
Copy link

codecov bot commented Sep 15, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (gh/zou3519/305/base@a382fe1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             gh/zou3519/305/base   #44649   +/-   ##
======================================================
  Coverage                       ?   68.08%           
======================================================
  Files                          ?      384           
  Lines                          ?    49763           
  Branches                       ?        0           
======================================================
  Hits                           ?    33880           
  Misses                         ?    15883           
  Partials                       ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a382fe1...b3442a4. Read the comment docs.

@zou3519
Update on "Add batching rule for "is_complex", "conj""
90ff985 
To unblock #43208, which adds "is_complex" checks to backward formulas
that are being tested for batched gradient support with vmap.

Test Plan:
- `pytest test/test_vmap.py -v`

Differential Revision: [D23685356](https://our.internmc.facebook.com/intern/diff/D23685356)

[ghstack-poisoned]
zou3519 added a commit that referenced this pull request Sep 15, 2020
@zou3519
Add batching rule for "is_complex", "conj"
ac6e540 
To unblock #43208, which adds "is_complex" checks to backward formulas
that are being tested for batched gradient support with vmap.

Test Plan:
- `pytest test/test_vmap.py -v`

ghstack-source-id: f6dcd35
Pull Request resolved: #44649
@anjali411 anjali411 added the module: complex Related to complex number support in PyTorch label Sep 15, 2020
@zou3519
Update on "Add batching rule for "is_complex", "conj""
b3442a4 
To unblock #43208, which adds "is_complex" checks to backward formulas
that are being tested for batched gradient support with vmap.

Test Plan:
- `pytest test/test_vmap.py -v`

Differential Revision: [D23685356](https://our.internmc.facebook.com/intern/diff/D23685356)

[ghstack-poisoned]
zou3519 added a commit that referenced this pull request Sep 16, 2020
@zou3519
Add batching rule for "is_complex", "conj"
67f6d4c 
To unblock #43208, which adds "is_complex" checks to backward formulas
that are being tested for batched gradient support with vmap.

Test Plan:
- `pytest test/test_vmap.py -v`

ghstack-source-id: 596cb16
Pull Request resolved: #44649
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 16, 2020

@zou3519 merged this pull request in 1cd5ba4.

@zou3519 zou3519 mentioned this pull request Sep 16, 2020
Closed
xuzhao9 pushed a commit that referenced this pull request Sep 18, 2020
@zou3519 @xuzhao9
Add batching rule for "is_complex", "conj" (#44649)
b58771d 
Summary:
Pull Request resolved: #44649

To unblock #43208, which adds "is_complex" checks to backward formulas
that are being tested for batched gradient support with vmap.

Test Plan: - `pytest test/test_vmap.py -v`

Reviewed By: anjali411

Differential Revision: D23685356

Pulled By: zou3519

fbshipit-source-id: 29e41a9296336f6d1008e3040cade4c643bf5ebf
@facebook-github-bot facebook-github-bot deleted the gh/zou3519/305/head branch September 20, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anjali411 anjali411 anjali411 approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@cpuhrsch cpuhrsch Awaiting requested review from cpuhrsch

Assignees

No one assigned

Labels

Merged module: complex Related to complex number support in PyTorch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zou3519 @facebook-github-bot @anjali411 @mruberry