Skip to content

[docs] torch.min/max: remove incorrect warning from docs #44615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kshitij12345 wants to merge 7 commits into from
Closed

[docs] torch.min/max: remove incorrect warning from docs #44615

kshitij12345 wants to merge 7 commits into from

Conversation

@kshitij12345
Copy link
Collaborator

@kshitij12345 kshitij12345 commented Sep 13, 2020

Fixes #44195

cc: @mruberry

@dr-ci
Copy link

dr-ci bot commented Sep 13, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit a655186 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_cuda9_2_cudnn7_py3_gcc5_4_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

atus(256)), stdout: "", stderr: "/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c: In function \'main\':\n/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: error: \'strtod_l\' undeclared (first use in this function)\n return ((int*)(&strtod_l))[argc];\n ^\n/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: note: each undeclared identifier is reported only once for each function it appears in\n" } 
Sep 15 10:07:45 [100%] Linking CXX executable test_custom_backend 
Sep 15 10:07:45 /usr/bin/cmake -E cmake_link_script CMakeFiles/test_custom_backend.dir/link.txt --verbose=1 
s.so /usr/lib/x86_64-linux-gnu/libcudnn.so -Wl,--no-as-needed,"/opt/conda/lib/python3.6/site-packages/torch/lib/libtorch.so" -Wl,--as-needed /opt/conda/lib/python3.6/site-packages/torch/lib/libc10.so -lcuda /usr/local/cuda/lib64/libnvrtc.so /usr/local/cuda/lib64/libnvToolsExt.so /usr/local/cuda/lib64/libcudart.so /opt/conda/lib/python3.6/site-packages/torch/lib/libc10_cuda.so -Wl,-rpath,/var/lib/jenkins/custom-backend-build:/opt/conda/lib/python3.6/site-packages/torch/lib:/usr/local/cuda/lib64  
Sep 15 10:07:45 make[2]: Leaving directory '/var/lib/jenkins/custom-backend-build' 
Sep 15 10:07:45 [100%] Built target test_custom_backend 
Sep 15 10:07:45 make[1]: Leaving directory '/var/lib/jenkins/custom-backend-build' 
Sep 15 10:07:45 /usr/bin/cmake -E cmake_progress_start /var/lib/jenkins/custom-backend-build/CMakeFiles 0 
Sep 15 10:07:45 ~/workspace 
Sep 15 10:07:45 EXITED_USER_LAND 
Sep 15 10:07:45 =================== sccache compilation log =================== 
tus(256)), stdout: "", stderr: "/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c: In function \'main\':\n/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: error: \'strtod_l\' undeclared (first use in this function)\n   return ((int*)(&strtod_l))[argc];\n                   ^\n/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: note: each undeclared identifier is reported only once for each function it appears in\n" } 
Sep 15 10:07:45  
Sep 15 10:07:45 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Sep 15 10:07:45 Compile requests             10647 
Sep 15 10:07:45 Compile requests executed     4443 
Sep 15 10:07:45 Cache hits                    4313 
Sep 15 10:07:45 Cache misses                   117 
Sep 15 10:07:45 Cache timeouts                   0 
Sep 15 10:07:45 Cache read errors                0 
Sep 15 10:07:45 Forced recaches                  0 
Sep 15 10:07:45 Cache write errors               0
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 15 times.

@codecov
Copy link

codecov bot commented Sep 13, 2020 •
edited
Loading

Codecov Report

Merging #44615 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #44615   +/-   ##
=======================================
  Coverage   67.98%   67.98%           
=======================================
  Files         384      384           
  Lines       49567    49567           
=======================================
  Hits        33696    33696           
  Misses      15871    15871
Impacted Files Coverage Δ
torch/_torch_docs.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e91728...955cd95. Read the comment docs.

@mruberry
Copy link
Collaborator

mruberry commented Sep 13, 2020

Should this also add a sentence to the first paragraph of the min/max documentation saying that if there are multiple minima/maxima then the index of the FIRST minima/maxima will be returned?

mruberry
mruberry reviewed Sep 14, 2020
View reviewed changes
mruberry
mruberry reviewed Sep 14, 2020
View reviewed changes
@kshitij12345
Copy link
Collaborator Author

kshitij12345 commented Sep 14, 2020

@mruberry PTAL:)

@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 15, 2020
mruberry
mruberry approved these changes Sep 15, 2020
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks @kshitij12345!

facebook-github-bot
facebook-github-bot reviewed Sep 15, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@kshitij12345
Copy link
Collaborator Author

kshitij12345 commented Sep 15, 2020

@mruberry Thanks for the fix!!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 15, 2020

@mruberry merged this pull request in 1d733d6.

@kshitij12345 kshitij12345 deleted the fix/minmax/docs-warning branch September 15, 2020 18:36
xuzhao9 pushed a commit that referenced this pull request Sep 18, 2020
@kshitij12345 @xuzhao9
[docs] torch.min/max: remove incorrect warning from docs (#44615)
848eb5c 
Summary:
Fixes #44195

cc: mruberry

Pull Request resolved: #44615

Reviewed By: ngimel

Differential Revision: D23703525

Pulled By: mruberry

fbshipit-source-id: 471ebd764be667e29c03a30f3ef341440adc54d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@mruberry mruberry mruberry approved these changes

Assignees

No one assigned

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove torch.max/min warning

5 participants

@kshitij12345 @mruberry @facebook-github-bot @ngimel @pytorchbot