[quant] Support clone for per channel affine quantized tensor #44573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…sor" Summary: fixes: #33309 Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
requested review from
VitalyFedyunin and
bhosmer
and removed request for
bhosmer
jerryzh168
commented
Sep 11, 2020
| self.q_per_channel_zero_points(), | ||
| self.q_per_channel_axis(), | ||
| self.options().memory_format(memory_format), | ||
| c10::nullopt); |
Contributor
Author
There was a problem hiding this comment.
@VitalyFedyunin is the memory format use correct? https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/native_functions.yaml#L1367
Contributor
There was a problem hiding this comment.
Yes, it looks like correct.
💊 CI failures summary and remediationsAs of commit 902446f (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
raghuramank100
approved these changes
Sep 14, 2020
VitalyFedyunin
approved these changes
Sep 14, 2020
Contributor
VitalyFedyunin
left a comment
VitalyFedyunin
left a comment
There was a problem hiding this comment.
Memory format usage is correct
| self.q_per_channel_zero_points(), | ||
| self.q_per_channel_axis(), | ||
| self.options().memory_format(memory_format), | ||
| c10::nullopt); |
Contributor
There was a problem hiding this comment.
Yes, it looks like correct.
…sor" Summary: fixes: #33309 Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23663828](https://our.internmc.facebook.com/intern/diff/D23663828) [ghstack-poisoned]
…sor" Summary: fixes: #33309 Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23663828](https://our.internmc.facebook.com/intern/diff/D23663828) [ghstack-poisoned]
…sor" Summary: fixes: #33309 Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23663828](https://our.internmc.facebook.com/intern/diff/D23663828) [ghstack-poisoned]
…sor" Summary: fixes: #33309 Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23663828](https://our.internmc.facebook.com/intern/diff/D23663828) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 3f5bb2b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
fixes: #33309
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D23663828