[quant] Fixing the output shape for the linear #44513
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
jerryzh168
approved these changes
Sep 10, 2020
Contributor
|
Is there a test exercising this path? |
Author
I don't think so -- it was not caught by a unittest. I guess, I'll add a test |
💊 CI failures summary and remediationsAs of commit 3b106ed (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 5 times. |
Differential Revision: [D23637508](https://our.internmc.facebook.com/intern/diff/D23637508) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/z-a-f/61/base #44513 +/- ##
====================================================
- Coverage 67.98% 67.98% -0.01%
====================================================
Files 384 384
Lines 49567 49567
====================================================
- Hits 33697 33696 -1
- Misses 15870 15871 +1
Continue to review full report at Codecov.
|
Contributor
xuzhao9
pushed a commit
that referenced
this pull request
Sep 18, 2020
Summary: Pull Request resolved: #44513 Test Plan: Imported from OSS Reviewed By: jerryzh168 Differential Revision: D23637508 Pulled By: z-a-f fbshipit-source-id: d19d4c1b234b05e8d9813e864863d937b6c35bf5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D23637508