Skip to content

[PyTorch Mobile] Move some string ops to register_prim_ops.cpp and make them selective #44500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iseeyuan wants to merge 1 commit into from
Closed

[PyTorch Mobile] Move some string ops to register_prim_ops.cpp and make them selective #44500

iseeyuan wants to merge 1 commit into from

Conversation

@iseeyuan
Copy link
Contributor

@iseeyuan iseeyuan commented Sep 10, 2020

Summary: Some user models are using those operators. Unblock them while keep the ops selective.

Test Plan: CI

Differential Revision: D23634769

@iseeyuan iseeyuan requested a review from apaszke as a code owner September 10, 2020 21:01
@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue fb-exported labels Sep 10, 2020
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 10, 2020

This pull request was exported from Phabricator. Differential Revision: D23634769

@dr-ci
Copy link

dr-ci bot commented Sep 10, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit ae789a2 (more details on the Dr. CI page):

  • 3/3 failures possibly* introduced in this PR
    • 2/3 non-CircleCI failure(s)

1 job timed out:

  • pytorch_linux_bionic_py3_8_gcc9_coverage_test

Extra GitHub checks: 1 failed

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 7 times.

@codecov
Copy link

codecov bot commented Sep 11, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@41f62b1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #44500   +/-   ##
=========================================
  Coverage          ?   68.05%           
=========================================
  Files             ?      382           
  Lines             ?    49468           
  Branches          ?        0           
=========================================
  Hits              ?    33667           
  Misses            ?    15801           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41f62b1...ae789a2. Read the comment docs.

@iseeyuan @facebook-github-bot
[PyTorch Mobile] Move some string ops to register_prim_ops.cpp and ma…
ae789a2 
…ke them selective (pytorch#44500)

Summary:
Pull Request resolved: pytorch#44500

Some user models are using those operators. Unblock them while keep the ops selective.

Test Plan: CI

Reviewed By: linbinyu

Differential Revision: D23634769

fbshipit-source-id: ef3e1483b62dde30473433c6c09684ee79a41269
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 11, 2020

This pull request was exported from Phabricator. Differential Revision: D23634769

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 11, 2020

This pull request has been merged in b73b44f.

xuzhao9 pushed a commit that referenced this pull request Sep 18, 2020
@iseeyuan @xuzhao9
[PyTorch Mobile] Move some string ops to register_prim_ops.cpp and ma…
8173f30 
…ke them selective (#44500)

Summary:
Pull Request resolved: #44500

Some user models are using those operators. Unblock them while keep the ops selective.

Test Plan: CI

Reviewed By: linbinyu

Differential Revision: D23634769

fbshipit-source-id: 55841d1b07136b6a27b6a39342f321638dc508cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

fb-exported Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iseeyuan @facebook-github-bot @mruberry