[quant][graphmode][jit][api] Expose preserved_attrs from finalize to convert_jit #44490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…convert_jit Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
…inalize to convert_jit" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23631142](https://our.internmc.facebook.com/intern/diff/D23631142) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 8af1a94 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 20 times. |
…inalize to convert_jit" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23631142](https://our.internmc.facebook.com/intern/diff/D23631142) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/jerryzh168/429/base #44490 +/- ##
=======================================================
Coverage 67.85% 67.85%
=======================================================
Files 384 384
Lines 50020 50022 +2
=======================================================
+ Hits 33940 33942 +2
Misses 16080 16080
Continue to review full report at Codecov.
|
…inalize to convert_jit" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23631142](https://our.internmc.facebook.com/intern/diff/D23631142) [ghstack-poisoned]
z-a-f
approved these changes
Sep 21, 2020
Comment on lines
76
to
78
| Module Finalize(Module& module, | ||
| QuantType quant_type, | ||
| const std::vector<std::string>& preserved_attrs) { |
Contributor
Author
There was a problem hiding this comment.
you mean does this affect BC? I don't think so, these is an internal function.
for user function convert_jit this is an optional argument, so it won't affect BC either.
…inalize to convert_jit" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23631142](https://our.internmc.facebook.com/intern/diff/D23631142) [ghstack-poisoned]
…inalize to convert_jit" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23631142](https://our.internmc.facebook.com/intern/diff/D23631142) [ghstack-poisoned]
…inalize to convert_jit" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23631142](https://our.internmc.facebook.com/intern/diff/D23631142) [ghstack-poisoned]
Contributor
|
This pull request has been merged in f575df2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D23631142