Add reset_grad() function (#42754) #44423
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D23010859 |
💊 CI failures summary and remediationsAs of commit 9b1dbe4 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 15 times. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D23010859 |
ngimel
force-pushed
the
export-D23010859
branch
from
25b1c02 to
4bf362c
Compare
ngimel
force-pushed
the
export-D23010859
branch
from
4bf362c to
e6c213b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D23010859 |
ngimel
force-pushed
the
export-D23010859
branch
from
e6c213b to
7c84b0e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D23010859 |
mcarilli
reviewed
Sep 9, 2020
torch/nn/modules/module.py
Outdated
mcarilli
reviewed
Sep 9, 2020
torch/optim/optimizer.py
Outdated
Collaborator
There was a problem hiding this comment.
``zero_grad(set_to_none=True)`` followed by a backward pass, ``.grad``\ s
mcarilli
reviewed
Sep 9, 2020
torch/optim/optimizer.py
Outdated
Summary: Pull Request resolved: pytorch#44423 Pull Request resolved: pytorch#42754 Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D23010859 Pulled By: ngimel fbshipit-source-id: 760279f7c9cb84d11bef51207c18bf1f362ca7ad
ngimel
force-pushed
the
export-D23010859
branch
from
7c84b0e to
9b1dbe4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D23010859 |
Codecov Report
@@ Coverage Diff @@
## master #44423 +/- ##
=======================================
Coverage 67.99% 67.99%
=======================================
Files 382 382
Lines 49385 49389 +4
=======================================
+ Hits 33579 33582 +3
- Misses 15806 15807 +1
Continue to review full report at Codecov.
|
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 16, 2020
Summary: https://pytorch.org/tutorials/recipes/recipes/amp_recipe.html is live. Core amp docs should reference it. Also i fixed some typos in the `zero_grad` docs we ignored when git was behaving weirdly during ngimel 's merge of #44423. Pull Request resolved: #44725 Reviewed By: mruberry Differential Revision: D23723807 Pulled By: ngimel fbshipit-source-id: ca0b76365f8ca908bd978e3b38bf81857fa6c2a3
xuzhao9
pushed a commit
that referenced
this pull request
Sep 18, 2020
Summary: https://pytorch.org/tutorials/recipes/recipes/amp_recipe.html is live. Core amp docs should reference it. Also i fixed some typos in the `zero_grad` docs we ignored when git was behaving weirdly during ngimel 's merge of #44423. Pull Request resolved: #44725 Reviewed By: mruberry Differential Revision: D23723807 Pulled By: ngimel fbshipit-source-id: ca0b76365f8ca908bd978e3b38bf81857fa6c2a3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Pull Request resolved: #42754
Test Plan: Imported from OSS
Differential Revision: D23010859
Pulled By: firstprayer