Merge criterion_tests and new_criterion_tests. #44398
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These end up executing the same tests, so no reason to have them separate. [ghstack-poisoned]
These end up executing the same tests, so no reason to have them separate. Differential Revision: [D23600855](https://our.internmc.facebook.com/intern/diff/D23600855) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 4f72e7c (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 3 times. |
Codecov Report
@@ Coverage Diff @@
## gh/gchanan/321/base #44398 +/- ##
=======================================================
- Coverage 68.00% 68.00% -0.01%
=======================================================
Files 382 382
Lines 49380 49379 -1
=======================================================
- Hits 33579 33578 -1
Misses 15801 15801
Continue to review full report at Codecov.
|
Contributor
This was referenced Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
These end up executing the same tests, so no reason to have them separate.
Differential Revision: D23600855