Skip to content

Deprecate torch.norm and torch.functional.norm #44321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kurtamohler wants to merge 1 commit into from
Closed

Deprecate torch.norm and torch.functional.norm #44321

kurtamohler wants to merge 1 commit into from

Conversation

@kurtamohler
Copy link
Collaborator

@kurtamohler kurtamohler commented Sep 8, 2020

Part of #24802

@dr-ci
Copy link

dr-ci bot commented Sep 8, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 7daf611 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 9 times.

@codecov
Copy link

codecov bot commented Sep 8, 2020 •
edited
Loading

Codecov Report

Merging #44321 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #44321      +/-   ##
==========================================
- Coverage   67.99%   67.99%   -0.01%     
==========================================
  Files         382      382              
  Lines       49385    49385              
==========================================
- Hits        33580    33579       -1     
- Misses      15805    15806       +1
Impacted Files Coverage Δ
torch/jit/_recursive.py 94.01% <0.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b69c28d...7daf611. Read the comment docs.

mruberry
mruberry reviewed Sep 9, 2020
View reviewed changes
mruberry
mruberry reviewed Sep 9, 2020
View reviewed changes
mruberry
mruberry reviewed Sep 9, 2020
View reviewed changes
mruberry
mruberry reviewed Sep 9, 2020
View reviewed changes
mruberry
mruberry requested changes Sep 9, 2020
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Just need to move the warning to C++ and update the doc string.

@kurtamohler kurtamohler force-pushed the norm-deprecation branch 2 times, most recently from 708e162 to 1a852ae Compare September 9, 2020 21:02
mruberry
mruberry reviewed Sep 9, 2020
View reviewed changes
mruberry
mruberry reviewed Sep 9, 2020
View reviewed changes
@mruberry mruberry self-requested a review September 9, 2020 23:19
mruberry
mruberry approved these changes Sep 9, 2020
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @kurtamohler! I just made a couple minor suggestions. Sorry I was mistaken about trying to warn once from C++. Just ping me when we're good to go.

@kurtamohler
Copy link
Collaborator Author

kurtamohler commented Sep 10, 2020

It's good to go @mruberry!

facebook-github-bot
facebook-github-bot reviewed Sep 10, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 10, 2020

@mruberry merged this pull request in 28a23fc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@mruberry mruberry mruberry approved these changes

@mattip mattip Awaiting requested review from mattip

Assignees

No one assigned

Labels

Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kurtamohler @facebook-github-bot @mruberry @pytorchbot