[TensorExpr] Fuser: check node inputs' device before merging the node into a fusion group. #44241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into a fusion group. [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
💊 CI failures summary and remediationsAs of commit 1512462 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 2 times. |
Krovatkin
approved these changes
Sep 8, 2020
| for (auto const& input : listConstruct->inputs()) { | ||
| REQ(isFusableOnDevice(input->node())); | ||
| } | ||
| // We're merging listconstruct->cat. cat is the consumer and listconstruct |
Contributor
There was a problem hiding this comment.
nit: I wonder if this could be already handled by canHandle when we create a TEGroup out of `aten::cat?
Author
There was a problem hiding this comment.
Yeah, that function could use some TLC, I'll look into it as a follow-up if you don't mind.
Contributor
|
@ZolotukhinM merged this pull request in bd8e38c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D23554192