Skip to content

Annotate torch.utils.(tensorboard/show_pickle/hypify) #44216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
guilhermeleobas wants to merge 5 commits into from
Closed

Annotate torch.utils.(tensorboard/show_pickle/hypify) #44216

guilhermeleobas wants to merge 5 commits into from

Conversation

@guilhermeleobas
Copy link
Collaborator

@guilhermeleobas guilhermeleobas commented Sep 4, 2020

Fixes #44215

@guilhermeleobas guilhermeleobas added the module: typing Related to mypy type annotations label Sep 4, 2020
@guilhermeleobas guilhermeleobas self-assigned this Sep 4, 2020
@dr-ci
Copy link

dr-ci bot commented Sep 4, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 96e9188 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 22 times.

@guilhermeleobas guilhermeleobas marked this pull request as ready for review September 8, 2020 21:51
@codecov
Copy link

codecov bot commented Sep 8, 2020 •
edited
Loading

Codecov Report

Merging #44216 into master will increase coverage by 0.00%.
The diff coverage is 82.35%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #44216   +/-   ##
=======================================
  Coverage   67.97%   67.98%           
=======================================
  Files         384      384           
  Lines       49589    49593    +4     
=======================================
+ Hits        33710    33714    +4     
  Misses      15879    15879
Impacted Files Coverage Δ
torch/utils/hipify/hipify_python.py 28.98% <60.00%> (+0.32%) ⬆️
torch/utils/show_pickle.py 63.21% <75.00%> (+0.42%) ⬆️
torch/utils/tensorboard/_caffe2_graph.py 68.85% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 442957d...96e9188. Read the comment docs.

rgommers
rgommers approved these changes Sep 10, 2020
View reviewed changes
Copy link
Collaborator

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor comment, but CI is already green so it seems optional to address.

@rgommers
Copy link
Collaborator

rgommers commented Sep 10, 2020

@guilhermeleobas this does have a merge conflict. Can you rebase?

@rgommers
Copy link
Collaborator

rgommers commented Sep 11, 2020

Conflicting again, needs another rebase - that's the pain of one mypy.ini file, especially if you work on multiple items that have adjacent ignore_errors entries.

@rgommers rgommers requested a review from ezyang September 25, 2020 17:51
facebook-github-bot
facebook-github-bot reviewed Sep 28, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 30, 2020

@ezyang merged this pull request in 375a83e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@rgommers rgommers rgommers approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@malfet malfet Awaiting requested review from malfet

@ezyang ezyang Awaiting requested review from ezyang

Assignees

@guilhermeleobas guilhermeleobas

Labels

Merged module: typing Related to mypy type annotations open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable torch.utils.(tensorboard/show_pickle/hypify) typechecks during CI

5 participants

@guilhermeleobas @rgommers @facebook-github-bot @pytorchbot @mruberry