Skip to content

[Reland] Optimize code path for adaptive_avg_pool2d when output size is (1, 1) #44211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xwang233 wants to merge 10 commits into from
Closed

[Reland] Optimize code path for adaptive_avg_pool2d when output size is (1, 1) #44211

xwang233 wants to merge 10 commits into from

Conversation

@xwang233
Copy link
Collaborator

@xwang233 xwang233 commented Sep 4, 2020 •
edited
Loading

Reland of #43986

DO NOT MERGE YET. XLA failure seems real.

@xwang233 xwang233 mentioned this pull request Sep 4, 2020
Closed
@dr-ci
Copy link

dr-ci bot commented Sep 4, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 2f5fdd1 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 8 times.

@xwang233 xwang233 requested a review from ngimel September 4, 2020 19:19
@ailzhang
Copy link
Contributor

ailzhang commented Sep 9, 2020

pytorch/xla#2484 should have fixed the xla test failure.(thanks @JackCaoG !) Rerunning to make sure.

@xwang233
Copy link
Collaborator Author

xwang233 commented Sep 9, 2020

@ailzhang @JackCaoG Thanks for the fix!

facebook-github-bot
facebook-github-bot reviewed Sep 9, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Sep 9, 2020 •
edited
Loading

Codecov Report

Merging #44211 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #44211      +/-   ##
==========================================
- Coverage   69.24%   69.24%   -0.01%     
==========================================
  Files         381      381              
  Lines       47577    47577              
==========================================
- Hits        32947    32946       -1     
- Misses      14630    14631       +1
Impacted Files Coverage Δ
torch/testing/_internal/expecttest.py 77.55% <0.00%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d62d3...2f5fdd1. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 9, 2020

@ngimel merged this pull request in ef4475f.

@facebook-github-bot facebook-github-bot deleted the ci-all/adaptive_avg_pool2d_output_size_1x1-reland1 branch January 27, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@xwang233 @ailzhang @facebook-github-bot @ngimel @pytorchbot @mruberry