Skip to content

torch.view_as_complex fails with segfault for a zero dimensional tensor #44175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
guol-fnst wants to merge 3 commits into from
Closed

torch.view_as_complex fails with segfault for a zero dimensional tensor #44175

guol-fnst wants to merge 3 commits into from

Conversation

@guol-fnst
Copy link
Contributor

@guol-fnst guol-fnst commented Sep 4, 2020 •
edited
Loading

Fixes #44061

@dr-ci
Copy link

dr-ci bot commented Sep 4, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit d81e460 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 11 times.

@codecov
Copy link

codecov bot commented Sep 4, 2020 •
edited
Loading

Codecov Report

Merging #44175 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #44175   +/-   ##
=======================================
  Coverage   67.99%   67.99%           
=======================================
  Files         382      382           
  Lines       49385    49385           
=======================================
  Hits        33580    33580           
  Misses      15805    15805

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ee3130...d81e460. Read the comment docs.

@guol-fnst guol-fnst closed this Sep 4, 2020
@guol-fnst guol-fnst reopened this Sep 4, 2020
@VinodSKumar VinodSKumar mentioned this pull request Sep 4, 2020
Closed
@guol-fnst
Copy link
Contributor Author

guol-fnst commented Sep 8, 2020

Hi @anjali411
Could you please help to review this PR?
Thanks!

anjali411
anjali411 reviewed Sep 8, 2020
View reviewed changes
anjali411
anjali411 approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@anjali411 anjali411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @guol-fnst

@anjali411 anjali411 added the module: complex Related to complex number support in PyTorch label Sep 8, 2020
VinodSKumar
VinodSKumar reviewed Sep 9, 2020
View reviewed changes
facebook-github-bot
facebook-github-bot reviewed Sep 10, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 11, 2020

@anjali411 merged this pull request in b6b1c01.

xuzhao9 pushed a commit that referenced this pull request Sep 18, 2020
@guol-fnst @xuzhao9
torch.view_as_complex fails with segfault for a zero dimensional tens…
03178cc 
…or (#44175)

Summary:
Fixes #44061

Pull Request resolved: #44175

Reviewed By: colesbury

Differential Revision: D23628103

Pulled By: anjali411

fbshipit-source-id: 6f70b5824150121a1617c0757499832923ae02b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@anjali411 anjali411 anjali411 approved these changes

+1 more reviewer

@VinodSKumar VinodSKumar VinodSKumar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged module: complex Related to complex number support in PyTorch open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Segmentation Fault: torch.view_as_complex fails with segfault for a zero dimensional tensor

6 participants

@guol-fnst @facebook-github-bot @VinodSKumar @anjali411 @pytorchbot @mruberry