Skip to content

Enable typechecks for torch.nn.quantized.modules.linear #44154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 2 commits into from
Closed

Enable typechecks for torch.nn.quantized.modules.linear #44154

malfet wants to merge 2 commits into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Sep 3, 2020

Also import Optional directly from typing rather than from _jit_internal

@malfet
Enable typechecks for torch.nn.quantized.modules.linear
9e30327 
Also import `Optional` directly from typing rather than from jit_internal
@malfet malfet requested a review from apaszke as a code owner September 3, 2020 22:06
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Sep 3, 2020
facebook-github-bot
facebook-github-bot reviewed Sep 3, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dr-ci
Copy link

dr-ci bot commented Sep 3, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 1d95eaf (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 6 times.

@malfet malfet force-pushed the malfet/move-more-annotations-inline branch from a81b1ca to 1d95eaf Compare September 3, 2020 23:22
facebook-github-bot
facebook-github-bot reviewed Sep 4, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Sep 4, 2020 •
edited
Loading

Codecov Report

Merging #44154 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #44154   +/-   ##
=======================================
  Coverage   69.35%   69.35%           
=======================================
  Files         381      381           
  Lines       47267    47267           
=======================================
  Hits        32780    32780           
  Misses      14487    14487
Impacted Files Coverage Δ
torch/jit/quantized.py 56.44% <100.00%> (ø)
torch/nn/quantized/dynamic/modules/embeddingbag.py 92.13% <100.00%> (ø)
torch/nn/quantized/modules/linear.py 91.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3da9e3...1d95eaf. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 4, 2020

@malfet merged this pull request in b60ffcd.

@malfet malfet deleted the malfet/move-more-annotations-inline branch September 4, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@rgommers rgommers rgommers approved these changes

@seemethere seemethere seemethere approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet @facebook-github-bot @rgommers @seemethere @mruberry