Skip to content

Add typing annotations for torch.utils.data.* modules #44136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
guilhermeleobas wants to merge 3 commits into from
Closed

Add typing annotations for torch.utils.data.* modules #44136

guilhermeleobas wants to merge 3 commits into from

Conversation

@guilhermeleobas
Copy link
Collaborator

@guilhermeleobas guilhermeleobas commented Sep 3, 2020

Fixes #44135

@guilhermeleobas guilhermeleobas added the module: typing Related to mypy type annotations label Sep 3, 2020
@guilhermeleobas guilhermeleobas self-assigned this Sep 3, 2020
@dr-ci
Copy link

dr-ci bot commented Sep 3, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 98dde4e (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 19 times.

@codecov
Copy link

codecov bot commented Sep 5, 2020 •
edited
Loading

Codecov Report

Merging #44136 into master will increase coverage by 0.10%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #44136      +/-   ##
==========================================
+ Coverage   69.24%   69.35%   +0.10%     
==========================================
  Files         381      381              
  Lines       47573    47266     -307     
==========================================
- Hits        32943    32781     -162     
+ Misses      14630    14485     -145
Impacted Files Coverage Δ
torch/utils/data/_utils/worker.py 21.49% <33.33%> (+0.74%) ⬆️
torch/utils/data/distributed.py 75.00% <75.00%> (ø)
torch/distributed/nn/api/remote_module.py 34.21% <0.00%> (-10.53%) ⬇️
torch/testing/_internal/hypothesis_utils.py 81.76% <0.00%> (-0.88%) ⬇️
torch/testing/__init__.py 95.28% <0.00%> (-0.53%) ⬇️
torch/jit/quantized.py 56.44% <0.00%> (-0.17%) ⬇️
torch/jit/annotations.py 92.27% <0.00%> (-0.14%) ⬇️
torch/quantization/fx/quantize.py 96.54% <0.00%> (-0.12%) ⬇️
torch/onnx/symbolic_opset9.py 35.24% <0.00%> (-0.12%) ⬇️
torch/onnx/symbolic_opset11.py 23.13% <0.00%> (-0.06%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cce5982...98dde4e. Read the comment docs.

@guilhermeleobas guilhermeleobas marked this pull request as ready for review September 8, 2020 21:50
@guilhermeleobas guilhermeleobas requested review from rgommers and removed request for apaszke September 8, 2020 21:50
@guilhermeleobas
Copy link
Collaborator Author

guilhermeleobas commented Sep 8, 2020

PR is ready for review. Failure doesn't seem to be caused by any changes introduced in this PR. cc @rgommers

rgommers
rgommers approved these changes Sep 10, 2020
View reviewed changes
Copy link
Collaborator

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @guilhermeleobas

@rgommers rgommers requested a review from malfet September 10, 2020 21:08
@rgommers rgommers requested a review from ezyang September 25, 2020 17:52
facebook-github-bot
facebook-github-bot reviewed Sep 28, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 30, 2020

@ezyang merged this pull request in eb39542.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@rgommers rgommers rgommers approved these changes

@malfet malfet Awaiting requested review from malfet

@ezyang ezyang Awaiting requested review from ezyang

Assignees

@guilhermeleobas guilhermeleobas

Labels

Merged module: typing Related to mypy type annotations open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable torch.utils.data.* typechecks during CI

5 participants

@guilhermeleobas @facebook-github-bot @rgommers @pytorchbot @mruberry