Skip to content

Conversation

@iseeyuan
Copy link
Contributor

@iseeyuan iseeyuan commented Sep 3, 2020

Summary: Pull Request resolved: #43985

Test Plan: Imported from OSS

Differential Revision: D23459774

Pulled By: iseeyuan

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23459774

@dr-ci
Copy link

dr-ci bot commented Sep 3, 2020

💊 CI failures summary and remediations

As of commit 936c405 (more details on the Dr. CI page):


  • 1/3 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)
  • 2/3 broken upstream at merge base 396469f since Sep 04

🚧 2 ongoing upstream failures:

These were probably caused by upstream breakages that are not fixed yet:


ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 6 times.

Summary:
Pull Request resolved: pytorch#43985

Added
```
def(detail::SelectiveStr<true>, ...)
impl(detail::SelectiveStr<true>, ...)
```
in torch/library, which can also be used for other templated selective registration.

Size saves for this diff:
fbios-pika: 78 KB
igios: 87 KB

Test Plan: Imported from OSS

Reviewed By: ljk53, smessmer

Differential Revision: D23459774

Pulled By: iseeyuan

fbshipit-source-id: 133fff99c817fee289039243f18c7acb5369a70f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23459774

@facebook-github-bot
Copy link
Contributor

@iseeyuan merged this pull request in 70c8daf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants