-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Add HIP/ROCm version to collect_env.py #44106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 246bce6 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
codecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 6 times. |
|
@jeffdaily Would this still be useful? |
|
@t-vi Sorry, this fell off my radar. Could you rebase this so that we could get some CI signal on this again? Do you have an AMD machine / could you paste some sample output from the script as well please? |
|
Yes, still useful. Thank you. LGTM. Verified on my own systems. |
|
Sample output from one of my systems: |
|
ROCm PyTorch: CUDA PyTorch on the same box (slightly different commit): |
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #44106 +/- ##
==========================================
- Coverage 67.98% 67.97% -0.01%
==========================================
Files 384 384
Lines 49590 49596 +6
==========================================
+ Hits 33712 33714 +2
- Misses 15878 15882 +4
Continue to review full report at Codecov.
|
Summary: This adds HIP version info to the `collect_env.py` output. Pull Request resolved: #44106 Reviewed By: VitalyFedyunin Differential Revision: D23652341 Pulled By: zou3519 fbshipit-source-id: a1f5bce8da7ad27a1277a95885934293d0fd43c5
This adds HIP version info to the
collect_env.pyoutput.