Enable typechecks for torch.nn.modules.[activation|upsampling] #44093
Conversation
Add missing `hardsigmoid`, `silu`, `hardswish` and `multi_head_attention_forward` to functional.pyi.in Embed some typing annotations into functional.py
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
💊 CI failures summary and remediationsAs of commit 5f94420 (more details on the Dr. CI page):
ci.pytorch.org: 2 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 9 times. |
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
LGTM, once CI is happy it should be good to merge.
malfet
force-pushed
the
malfet/enable-torch.nn.modules.activation-typing
branch
from
597fa44 to
5f94420
Compare
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #44093 +/- ##
=======================================
Coverage 69.24% 69.25%
=======================================
Files 381 381
Lines 47209 47210 +1
=======================================
+ Hits 32692 32693 +1
Misses 14517 14517
Continue to review full report at Codecov.
|
6 participants
Add missing
hardsigmoid,silu,hardswishandmulti_head_attention_forwardto functional.pyi.inEmbed some typing annotations into functional.py