Skip to content

[ONNX] Update narrow for dynamic inputs #44039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
neginraoof wants to merge 7 commits into from
Closed

[ONNX] Update narrow for dynamic inputs #44039

neginraoof wants to merge 7 commits into from

Conversation

@neginraoof
Copy link
Contributor

@neginraoof neginraoof commented Sep 2, 2020

Update narrow for dynamic inputs

@dr-ci
Copy link

dr-ci bot commented Sep 2, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit e0c79c0 (more details on the Dr. CI page):

  • 3/3 failures possibly* introduced in this PR
    • 3/3 non-CircleCI failure(s)

Extra GitHub checks: 1 failed

ci.pytorch.org: 1 failed

codecov.io: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 18 times.

@smessmer smessmer requested a review from houseroad September 2, 2020 21:18
@smessmer smessmer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 2, 2020
@neginraoof neginraoof requested a review from BowenBao September 10, 2020 05:41
@BowenBao
Copy link
Collaborator

BowenBao commented Sep 11, 2020

Please rebase for unrelated CI test failures.

@codecov
Copy link

codecov bot commented Sep 14, 2020 •
edited
Loading

Codecov Report

Merging #44039 into master will increase coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #44039   +/-   ##
=======================================
  Coverage   67.85%   67.85%           
=======================================
  Files         384      384           
  Lines       50020    50024    +4     
=======================================
+ Hits        33939    33942    +3     
- Misses      16081    16082    +1
Impacted Files Coverage Δ
torch/onnx/symbolic_opset11.py 22.70% <25.00%> (+0.02%) ⬆️
torch/utils/_benchmark/utils/common.py 79.33% <0.00%> (+1.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2f49c8...e0c79c0. Read the comment docs.

@neginraoof
Copy link
Contributor Author

neginraoof commented Sep 15, 2020

cc @bzinodev
Can we please merge this PR?
Thanks

facebook-github-bot
facebook-github-bot reviewed Sep 16, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@neginraoof
Copy link
Contributor Author

neginraoof commented Sep 18, 2020

@bzinodev Can we merge this PR please? Thanks!

@gchanan gchanan added this to the 1.7.0 milestone Sep 21, 2020
@neginraoof
Copy link
Contributor Author

neginraoof commented Sep 21, 2020

@bzinodev Can we merge this please?
Thanks.

@neginraoof
Copy link
Contributor Author

neginraoof commented Sep 22, 2020

@bzinodev Can we merge this PR please? Thanks!

facebook-github-bot
facebook-github-bot reviewed Sep 23, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 28, 2020

@bzinodev merged this pull request in 4005afe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@BowenBao BowenBao BowenBao approved these changes

@houseroad houseroad Awaiting requested review from houseroad

+1 more reviewer

@bzinodev bzinodev bzinodev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

8 participants

@neginraoof @BowenBao @facebook-github-bot @bzinodev @smessmer @gchanan @pytorchbot @mruberry