Actually run backward criterion tests. #44030
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks to have been a mistake from #9287. [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit d50cc53 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 8 times. |
This looks to have been a mistake from #9287. Differential Revision: [D23476274](https://our.internmc.facebook.com/intern/diff/D23476274) [ghstack-poisoned]
This was referenced Sep 2, 2020
Contributor
Author
|
I turned off the CTCLoss tests for now because they fail. |
Codecov Report
@@ Coverage Diff @@
## gh/gchanan/314/base #44030 +/- ##
======================================================
Coverage ? 69.42%
======================================================
Files ? 381
Lines ? 47168
Branches ? 0
======================================================
Hits ? 32747
Misses ? 14421
Partials ? 0 Continue to review full report at Codecov.
|
zou3519
approved these changes
Sep 3, 2020
Contributor
zou3519
left a comment
zou3519
left a comment
There was a problem hiding this comment.
I can't believe we didn't notice this for two years... Thanks for the fix!
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This looks to have been a mistake from #9287.
Differential Revision: D23476274